Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 207553003: [DevTools] Allow partial device metrics emulation. (Closed)

Created:
6 years, 9 months ago by dgozman
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[DevTools] Allow partial device metrics emulation. Zero widget size, device size or device scale factor will preserve the original value. BUG=327641 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -12 lines) Patch
M content/renderer/render_widget.cc View 5 chunks +40 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Hi, Could you please take a look? Follow-up blink patch with test which uses this: ...
6 years, 9 months ago (2014-03-25 13:22:49 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-25 16:28:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-26 08:29:43 UTC) #3
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-26 08:49:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/207553003/1
6 years, 9 months ago (2014-03-26 08:49:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 10:02:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-26 10:02:01 UTC) #7
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-26 10:10:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/207553003/1
6 years, 9 months ago (2014-03-26 10:10:53 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 12:32:11 UTC) #10
Message was sent while issue was closed.
Change committed as 259557

Powered by Google App Engine
This is Rietveld 408576698