Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: chrome/browser/safe_browsing/permission_reporter.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/permission_reporter.cc
diff --git a/chrome/browser/safe_browsing/permission_reporter.cc b/chrome/browser/safe_browsing/permission_reporter.cc
index 9b7e3b5660f2e9161a0aece5898b4f06f954b6d1..359deb50122f3ff6a6e15eb222cd0752747777f1 100644
--- a/chrome/browser/safe_browsing/permission_reporter.cc
+++ b/chrome/browser/safe_browsing/permission_reporter.cc
@@ -80,6 +80,24 @@ PermissionReport::Action PermissionActionForReport(PermissionAction action) {
return PermissionReport::ACTION_UNSPECIFIED;
}
+PermissionReport::SourceUI SourceUIForReport(PermissionSourceUI source_ui) {
+ switch (source_ui) {
+ case PermissionSourceUI::PROMPT:
+ return PermissionReport::PROMPT;
+ case PermissionSourceUI::OIB:
+ return PermissionReport::OIB;
+ case PermissionSourceUI::SITE_SETTINGS:
+ return PermissionReport::SITE_SETTINGS;
+ case PermissionSourceUI::PAGE_ACTION:
+ return PermissionReport::PAGE_ACTION;
+ case PermissionSourceUI::SOURCE_UI_NUM:
+ break;
+ }
+
+ NOTREACHED();
+ return PermissionReport::SOURCE_UI_UNSPECIFIED;
+}
+
} // namespace
bool PermissionAndOrigin::operator==(const PermissionAndOrigin& other) const {
@@ -112,11 +130,12 @@ PermissionReporter::~PermissionReporter() {}
void PermissionReporter::SendReport(const GURL& origin,
content::PermissionType permission,
- PermissionAction action) {
+ PermissionAction action,
+ PermissionSourceUI source_ui) {
if (IsReportThresholdExceeded(permission, origin))
return;
std::string serialized_report;
- BuildReport(origin, permission, action, &serialized_report);
+ BuildReport(origin, permission, action, source_ui, &serialized_report);
permission_report_sender_->Send(GURL(kPermissionActionReportingUploadUrl),
serialized_report);
}
@@ -125,11 +144,13 @@ void PermissionReporter::SendReport(const GURL& origin,
bool PermissionReporter::BuildReport(const GURL& origin,
PermissionType permission,
PermissionAction action,
+ PermissionSourceUI source_ui,
std::string* output) {
PermissionReport report;
report.set_origin(origin.spec());
report.set_permission(PermissionTypeForReport(permission));
report.set_action(PermissionActionForReport(action));
+ report.set_source_ui(SourceUIForReport(source_ui));
// Collect platform data.
#if defined(OS_ANDROID)
« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.h ('k') | chrome/browser/safe_browsing/permission_reporter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698