Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/browser/permissions/permission_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 66b61c041879fc803f0ae0baf9f708babed75130..a2c1c7948ad52f704d364c8d1360f9f0b71272ba 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -197,28 +197,33 @@ void PermissionUmaUtil::PermissionRequested(PermissionType permission,
void PermissionUmaUtil::PermissionGranted(PermissionType permission,
const GURL& requesting_origin,
Profile* profile) {
- RecordPermissionAction(permission, GRANTED, requesting_origin, profile);
+ RecordPermissionAction(permission, GRANTED, PermissionSourceUI::PROMPT,
+ requesting_origin, profile);
}
void PermissionUmaUtil::PermissionDenied(PermissionType permission,
const GURL& requesting_origin,
Profile* profile) {
- RecordPermissionAction(permission, DENIED, requesting_origin, profile);
+ RecordPermissionAction(permission, DENIED, PermissionSourceUI::PROMPT,
+ requesting_origin, profile);
}
void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
const GURL& requesting_origin,
Profile* profile) {
- RecordPermissionAction(permission, DISMISSED, requesting_origin, profile);
+ RecordPermissionAction(permission, DISMISSED, PermissionSourceUI::PROMPT,
+ requesting_origin, profile);
}
void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
const GURL& requesting_origin,
Profile* profile) {
- RecordPermissionAction(permission, IGNORED, requesting_origin, profile);
+ RecordPermissionAction(permission, IGNORED, PermissionSourceUI::PROMPT,
+ requesting_origin, profile);
}
void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
+ PermissionSourceUI source_ui,
const GURL& revoked_origin,
Profile* profile) {
// TODO(tsergeant): Expand metrics definitions for revocation to include all
@@ -227,7 +232,8 @@ void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
permission == PermissionType::GEOLOCATION ||
permission == PermissionType::AUDIO_CAPTURE ||
permission == PermissionType::VIDEO_CAPTURE) {
- RecordPermissionAction(permission, REVOKED, revoked_origin, profile);
+ RecordPermissionAction(permission, REVOKED, source_ui, revoked_origin,
+ profile);
}
}
@@ -330,6 +336,7 @@ bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
PermissionAction action,
+ PermissionSourceUI source_ui,
const GURL& requesting_origin,
Profile* profile) {
if (IsOptedIntoPermissionActionReporting(profile)) {
@@ -337,7 +344,8 @@ void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
// sent.
g_browser_process->safe_browsing_service()
->ui_manager()
- ->ReportPermissionAction(requesting_origin, permission, action);
+ ->ReportPermissionAction(requesting_origin, permission, action,
+ source_ui);
}
bool secure_origin = content::IsOriginSecure(requesting_origin);
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/browser/permissions/permission_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698