Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6026)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/safe_browsing/permission_report.proto

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove sourceui except from PermissionRevoked Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/safe_browsing/permission_reporter_unittest.cc ('K') | « chrome/browser/ui/website_settings/website_settings.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/safe_browsing/permission_report.proto
diff --git a/chrome/common/safe_browsing/permission_report.proto b/chrome/common/safe_browsing/permission_report.proto
index 4abd33dbd8e3cd1ef9dc3b634290b6a4139279c7..9ad2bf55f62be3757b667bf83cf73cf0f3ff46d4 100644
--- a/chrome/common/safe_browsing/permission_report.proto
+++ b/chrome/common/safe_browsing/permission_report.proto
@@ -53,8 +53,6 @@ message PermissionReport {
// User Permission Actions. This enum is intentionally different with
// the one in src/chrome/browser/permissions/permission_uma_util.h
enum Action {
- // TODO(stefanocs): Add ACTION_UNSPECIFIED to the corresponding Safe
- // Browsing logs proto.
ACTION_UNSPECIFIED = 0;
GRANTED = 1;
DENIED = 2;
@@ -68,9 +66,8 @@ message PermissionReport {
SOURCE_UI_UNSPECIFIED = 0;
PROMPT = 1;
OIB = 2;
- // TODO(stefanocs): Remove CONTENT_SETTINGS from the corresponding Safe
- // Browsing logs proto.
SITE_SETTINGS = 3;
+ PAGE_ACTION = 4;
}
// The various types of permissions. This should stay in sync with the
« chrome/browser/safe_browsing/permission_reporter_unittest.cc ('K') | « chrome/browser/ui/website_settings/website_settings.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698