Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment + TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 void PermissionUmaUtil::PermissionRequested(PermissionType permission, 189 void PermissionUmaUtil::PermissionRequested(PermissionType permission,
190 const GURL& requesting_origin, 190 const GURL& requesting_origin,
191 const GURL& embedding_origin, 191 const GURL& embedding_origin,
192 Profile* profile) { 192 Profile* profile) {
193 RecordPermissionRequest(permission, requesting_origin, embedding_origin, 193 RecordPermissionRequest(permission, requesting_origin, embedding_origin,
194 profile); 194 profile);
195 } 195 }
196 196
197 void PermissionUmaUtil::PermissionGranted(PermissionType permission, 197 void PermissionUmaUtil::PermissionGranted(PermissionType permission,
198 const GURL& requesting_origin, 198 const GURL& requesting_origin,
199 SourceUI source_ui,
199 Profile* profile) { 200 Profile* profile) {
200 RecordPermissionAction(permission, GRANTED, requesting_origin, profile); 201 RecordPermissionAction(permission, GRANTED, requesting_origin, source_ui,
202 profile);
201 } 203 }
202 204
203 void PermissionUmaUtil::PermissionDenied(PermissionType permission, 205 void PermissionUmaUtil::PermissionDenied(PermissionType permission,
204 const GURL& requesting_origin, 206 const GURL& requesting_origin,
207 SourceUI source_ui,
205 Profile* profile) { 208 Profile* profile) {
206 RecordPermissionAction(permission, DENIED, requesting_origin, profile); 209 RecordPermissionAction(permission, DENIED, requesting_origin, source_ui,
210 profile);
207 } 211 }
208 212
209 void PermissionUmaUtil::PermissionDismissed(PermissionType permission, 213 void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
210 const GURL& requesting_origin, 214 const GURL& requesting_origin,
215 SourceUI source_ui,
211 Profile* profile) { 216 Profile* profile) {
212 RecordPermissionAction(permission, DISMISSED, requesting_origin, profile); 217 RecordPermissionAction(permission, DISMISSED, requesting_origin, source_ui,
218 profile);
213 } 219 }
214 220
215 void PermissionUmaUtil::PermissionIgnored(PermissionType permission, 221 void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
216 const GURL& requesting_origin, 222 const GURL& requesting_origin,
223 SourceUI source_ui,
217 Profile* profile) { 224 Profile* profile) {
218 RecordPermissionAction(permission, IGNORED, requesting_origin, profile); 225 RecordPermissionAction(permission, IGNORED, requesting_origin, source_ui,
226 profile);
219 } 227 }
220 228
221 void PermissionUmaUtil::PermissionRevoked(PermissionType permission, 229 void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
222 const GURL& revoked_origin, 230 const GURL& revoked_origin,
231 SourceUI source_ui,
223 Profile* profile) { 232 Profile* profile) {
224 // TODO(tsergeant): Expand metrics definitions for revocation to include all 233 // TODO(tsergeant): Expand metrics definitions for revocation to include all
225 // permissions. 234 // permissions.
226 if (permission == PermissionType::NOTIFICATIONS || 235 if (permission == PermissionType::NOTIFICATIONS ||
227 permission == PermissionType::GEOLOCATION || 236 permission == PermissionType::GEOLOCATION ||
228 permission == PermissionType::AUDIO_CAPTURE || 237 permission == PermissionType::AUDIO_CAPTURE ||
229 permission == PermissionType::VIDEO_CAPTURE) { 238 permission == PermissionType::VIDEO_CAPTURE) {
230 RecordPermissionAction(permission, REVOKED, revoked_origin, profile); 239 RecordPermissionAction(permission, REVOKED, revoked_origin, source_ui,
240 profile);
231 } 241 }
232 } 242 }
233 243
234 void PermissionUmaUtil::PermissionPromptShown( 244 void PermissionUmaUtil::PermissionPromptShown(
235 const std::vector<PermissionBubbleRequest*>& requests) { 245 const std::vector<PermissionBubbleRequest*>& requests) {
236 DCHECK(!requests.empty()); 246 DCHECK(!requests.empty());
237 247
238 PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE; 248 PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE;
239 if (requests.size() == 1) 249 if (requests.size() == 1)
240 permission_prompt_type = requests[0]->GetPermissionBubbleType(); 250 permission_prompt_type = requests[0]->GetPermissionBubbleType();
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 return false; 335 return false;
326 if (!preferred_data_types.Has(syncer::PREFERENCES)) 336 if (!preferred_data_types.Has(syncer::PREFERENCES))
327 return false; 337 return false;
328 338
329 return true; 339 return true;
330 } 340 }
331 341
332 void PermissionUmaUtil::RecordPermissionAction(PermissionType permission, 342 void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
333 PermissionAction action, 343 PermissionAction action,
334 const GURL& requesting_origin, 344 const GURL& requesting_origin,
345 SourceUI source_ui,
335 Profile* profile) { 346 Profile* profile) {
336 if (IsOptedIntoPermissionActionReporting(profile)) { 347 if (IsOptedIntoPermissionActionReporting(profile)) {
337 g_browser_process->safe_browsing_service() 348 g_browser_process->safe_browsing_service()
338 ->ui_manager() 349 ->ui_manager()
339 ->ReportPermissionAction(requesting_origin, permission, action); 350 ->ReportPermissionAction(requesting_origin, permission, action,
351 source_ui);
340 } 352 }
341 353
342 bool secure_origin = content::IsOriginSecure(requesting_origin); 354 bool secure_origin = content::IsOriginSecure(requesting_origin);
343 355
344 switch (permission) { 356 switch (permission) {
345 case PermissionType::GEOLOCATION: 357 case PermissionType::GEOLOCATION:
346 PERMISSION_ACTION_UMA(secure_origin, "Permissions.Action.Geolocation", 358 PERMISSION_ACTION_UMA(secure_origin, "Permissions.Action.Geolocation",
347 "Permissions.Action.SecureOrigin.Geolocation", 359 "Permissions.Action.SecureOrigin.Geolocation",
348 "Permissions.Action.InsecureOrigin.Geolocation", 360 "Permissions.Action.InsecureOrigin.Geolocation",
349 action); 361 action);
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 if (!deprecated_metric.empty() && rappor_service) { 421 if (!deprecated_metric.empty() && rappor_service) {
410 rappor::SampleDomainAndRegistryFromGURL(rappor_service, deprecated_metric, 422 rappor::SampleDomainAndRegistryFromGURL(rappor_service, deprecated_metric,
411 requesting_origin); 423 requesting_origin);
412 424
413 std::string rappor_metric = deprecated_metric + "2"; 425 std::string rappor_metric = deprecated_metric + "2";
414 rappor_service->RecordSample( 426 rappor_service->RecordSample(
415 rappor_metric, rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE, 427 rappor_metric, rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
416 rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin)); 428 rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
417 } 429 }
418 } 430 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698