runtime/vm/flow_graph_compiler_x64.cc - Issue 20755004: Make sure that ICData always contains valid data (non-null values).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 20755004: Make sure that ICData always contains valid data (non-null values). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_x64.cc

===================================================================

--- runtime/vm/flow_graph_compiler_x64.cc (revision 25521)

+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)

@@ -1010,7 +1010,7 @@

// Invoke noSuchMethod function passing "call" as the original name.

const int kNumArgsChecked = 1;

const ICData& ic_data = ICData::ZoneHandle(

- ICData::New(function, Symbols::Call(), Object::null_array(),

+ ICData::New(function, Symbols::Call(), Object::empty_array(),

Isolate::kNoDeoptId, kNumArgsChecked));

__ LoadObject(RBX, ic_data);

__ LeaveFrame(); // The arguments are still on the stack.

@@ -1164,7 +1164,7 @@

: function.name());

const int kNumArgsChecked = 1;

const ICData& ic_data = ICData::ZoneHandle(

- ICData::New(function, name, Object::null_array(),

+ ICData::New(function, name, Object::empty_array(),

Isolate::kNoDeoptId, kNumArgsChecked));

__ LoadObject(RBX, ic_data);

__ LeaveFrame(); // The arguments are still on the stack.

« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/flow_graph_optimizer.h » ('j') | runtime/vm/object.cc » ('J')