Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2075493002: Add a regression test for bug #587 (Closed)

Created:
4 years, 6 months ago by stanm
Modified:
4 years, 6 months ago
Reviewers:
Jennifer Messerly
CC:
Jennifer Messerly
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A test/codegen/language/static_const_field_reserved_name_test.dart View 1 chunk +22 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
stanm
4 years, 6 months ago (2016-06-15 23:41:57 UTC) #1
Jennifer Messerly
LGTM! https://codereview.chromium.org/2075493002/diff/1/test/codegen/language/static_const_field_reserved_name_test.dart File test/codegen/language/static_const_field_reserved_name_test.dart (right): https://codereview.chromium.org/2075493002/diff/1/test/codegen/language/static_const_field_reserved_name_test.dart#newcode6 test/codegen/language/static_const_field_reserved_name_test.dart:6: // Bug #587. Might be worth linking the ...
4 years, 6 months ago (2016-06-15 23:43:19 UTC) #3
stanm
4 years, 6 months ago (2016-06-15 23:59:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8767a65179e18d70d7d06e4911db100abdac1a25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698