Chromium Code Reviews
DescriptionFix alert dialog output.
An alert dialog uses $descendants for its enter rule, but this potentially results in infinite recursion since a descendant's format rule may walk up to the alert dialog to format an ancestor. We should never use children in the formatting of enter rules.
A specific case where this hits is in the
google.com -> search by voice
permissions dialog. Moving forward from the close button results in the above mentioned infinite recursion.
BUG=619417, 619388
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/4d356e830cd6c653cf7979e16754faeef1e6f953
Cr-Commit-Position: refs/heads/master@{#400044}
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
|
|||||||||||||||||||