Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2075473002: Fix alert dialog output. (Closed)

Created:
4 years, 6 months ago by David Tseng
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix alert dialog output. An alert dialog uses $descendants for its enter rule, but this potentially results in infinite recursion since a descendant's format rule may walk up to the alert dialog to format an ancestor. We should never use children in the formatting of enter rules. A specific case where this hits is in the google.com -> search by voice permissions dialog. Moving forward from the close button results in the above mentioned infinite recursion. BUG=619417, 619388 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4d356e830cd6c653cf7979e16754faeef1e6f953 Cr-Commit-Position: refs/heads/master@{#400044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 6 months ago (2016-06-15 22:18:53 UTC) #4
dmazzoni
lgtm
4 years, 6 months ago (2016-06-15 22:20:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075473002/1
4 years, 6 months ago (2016-06-15 22:33:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 23:42:17 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 23:45:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d356e830cd6c653cf7979e16754faeef1e6f953
Cr-Commit-Position: refs/heads/master@{#400044}

Powered by Google App Engine
This is Rietveld 408576698