[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668
R=dpranke@chromium.org

Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Cr-Commit-Position: refs/heads/master@{#400047}

[Robert Sesek, 2016-06-15 21:53:30]

Description was changed from

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668
R=dpranke@chromium.org
==========

to

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668
R=dpranke@chromium.org
==========

[Dirk Pranke, 2016-06-15 22:11:40]

https://codereview.chromium.org/2075463002/diff/1/build/toolchain/mac/copy_bu...
File build/toolchain/mac/copy_bundle_data.py (right):

https://codereview.chromium.org/2075463002/diff/1/build/toolchain/mac/copy_bu...
build/toolchain/mac/copy_bundle_data.py:86: ['rsync', '--recursive', '--perms',
'--links', source, dest])
I'm not sure if this'll do the right thing.

If you want to copy a directory, won't rsync do two different things based on
what exactly the arguments are (whether there is a trailing slash for a
directory name) and whether the destination directory already exists?

[Robert Sesek, 2016-06-15 22:31:16]

https://codereview.chromium.org/2075463002/diff/1/build/toolchain/mac/copy_bu...
File build/toolchain/mac/copy_bundle_data.py (right):

https://codereview.chromium.org/2075463002/diff/1/build/toolchain/mac/copy_bu...
build/toolchain/mac/copy_bundle_data.py:86: ['rsync', '--recursive', '--perms',
'--links', source, dest])
On 2016/06/15 22:11:40, Dirk Pranke wrote:
> I'm not sure if this'll do the right thing.
> 
> If you want to copy a directory, won't rsync do two different things based on
> what exactly the arguments are (whether there is a trailing slash for a
> directory name) and whether the destination directory already exists?

Good catch. Will strip the trailing slash(es) on the source, but it doesn't
affect the destination. Also, the destination is always going to be removed (see
above).

[Dirk Pranke, 2016-06-15 22:33:11]

lgtm

[Robert Sesek, 2016-06-15 23:36:13]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2016-06-15 23:36:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075463002/20001

[commit-bot: I haz the power, 2016-06-15 23:50:38]

Description was changed from

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668
R=dpranke@chromium.org
==========

to

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668
R=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-06-15 23:50:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-15 23:53:06]

Description was changed from

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668
R=dpranke@chromium.org
==========

to

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668
R=dpranke@chromium.org

Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Cr-Commit-Position: refs/heads/master@{#400047}
==========

[commit-bot: I haz the power, 2016-06-15 23:53:07]

Patchset 2 (id:??) landed as
https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Cr-Commit-Position: refs/heads/master@{#400047}

[dmazzoni, 2016-06-16 03:24:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2074523003/ by dmazzoni@chromium.org.

The reason for reverting is: Broke both Mac GN builders; tests are failing with
errors such as:

AcceleratorsCocoaBrowserTest.MainMenuAcceleratorsInMapping (run #1):
[ RUN      ] AcceleratorsCocoaBrowserTest.MainMenuAcceleratorsInMapping
[1361:515:0615/193339:210535270587:FATAL:crashpad_client_mac.cc(411)] execvp
/b/swarm_slave/work/isolated/isolated_runTnrdHD/out/Release/Chromium.app/Contents/Versions/53.0.2769.0/Chromium
Framework.framework/Helpers/crashpad_handler: No such file or directory
.