SkPerlinNoiseShader::CreateTubulenceNoise() is misspelled

SkPerlinNoiseShader::CreateTubulenceNoise() is misspelled

Add missing 'r'.

BUG=skia:2329
Committed: http://code.google.com/p/skia/source/detail?r=14008

[siglesias, 2014-03-25 07:54:47]

The CQ bit was checked by siglesias@igalia.com

[siglesias, 2014-03-25 07:54:48]

The CQ bit was unchecked by siglesias@igalia.com

[bsalomon, 2014-03-25 13:19:41]

The change looks fine but there are two issues:

1) I think you need to sign a license agreement form to be added to the authors
file, and

2) I would guess that Chromium or Blink uses the old spelling and we may need to
temporarily alias the factory function name until that code is also updated.

I added hcm@ for details on the first and sugoi@ for the second.

[hcm, 2014-03-25 13:30:57]

On 2014/03/25 13:19:41, bsalomon wrote:
> The change looks fine but there are two issues:
> 
> 1) I think you need to sign a license agreement form to be added to the
authors
> file, and
> 
> 2) I would guess that Chromium or Blink uses the old spelling and we may need
to
> temporarily alias the factory function name until that code is also updated.
> 
> I added hcm@ for details on the first and sugoi@ for the second.

If you are contributing on behalf of Igalia, I've confirmed they have signed the
Google Corporate CLA.  We just need you to add a line to the Skia trunk/AUTHORS
file for Igalia.  That change can be added to this CL and the commit check
should work.

[bsalomon, 2014-03-25 13:32:31]

On 2014/03/25 13:30:57, hcm wrote:
> On 2014/03/25 13:19:41, bsalomon wrote:
> > The change looks fine but there are two issues:
> > 
> > 1) I think you need to sign a license agreement form to be added to the
> authors
> > file, and
> > 
> > 2) I would guess that Chromium or Blink uses the old spelling and we may
need
> to
> > temporarily alias the factory function name until that code is also updated.
> > 
> > I added hcm@ for details on the first and sugoi@ for the second.
> 
> If you are contributing on behalf of Igalia, I've confirmed they have signed
the
> Google Corporate CLA.  We just need you to add a line to the Skia
trunk/AUTHORS
> file for Igalia.  That change can be added to this CL and the commit check
> should work.

Oh great, that line is already in the changelist. So we're good on that front.

[hcm, 2014-03-25 13:34:55]

On 2014/03/25 13:32:31, bsalomon wrote:
> On 2014/03/25 13:30:57, hcm wrote:
> > On 2014/03/25 13:19:41, bsalomon wrote:
> > > The change looks fine but there are two issues:
> > > 
> > > 1) I think you need to sign a license agreement form to be added to the
> > authors
> > > file, and
> > > 
> > > 2) I would guess that Chromium or Blink uses the old spelling and we may
> need
> > to
> > > temporarily alias the factory function name until that code is also
updated.
> > > 
> > > I added hcm@ for details on the first and sugoi@ for the second.
> > 
> > If you are contributing on behalf of Igalia, I've confirmed they have signed
> the
> > Google Corporate CLA.  We just need you to add a line to the Skia
> trunk/AUTHORS
> > file for Igalia.  That change can be added to this CL and the commit check
> > should work.
> 
> Oh great, that line is already in the changelist. So we're good on that front.

Yep, didn't see that- looks great!

[siglesias, 2014-04-01 08:36:42]

On 2014/03/25 13:34:55, hcm wrote:
> On 2014/03/25 13:32:31, bsalomon wrote:
> > On 2014/03/25 13:30:57, hcm wrote:
> > > On 2014/03/25 13:19:41, bsalomon wrote:
> > > > The change looks fine but there are two issues:
> > > > 
> > > > 1) I think you need to sign a license agreement form to be added to the
> > > authors
> > > > file, and
> > > > 
> > > > 2) I would guess that Chromium or Blink uses the old spelling and we may
> > need
> > > to
> > > > temporarily alias the factory function name until that code is also
> updated.
> > > > 
> > > > I added hcm@ for details on the first and sugoi@ for the second.
> > > 
> > > If you are contributing on behalf of Igalia, I've confirmed they have
signed
> > the
> > > Google Corporate CLA.  We just need you to add a line to the Skia
> > trunk/AUTHORS
> > > file for Igalia.  That change can be added to this CL and the commit check
> > > should work.
> > 
> > Oh great, that line is already in the changelist. So we're good on that
front.
> 
> Yep, didn't see that- looks great!

Is there any news on the Chromium/Blink side? Shall I update the patch with the
alias?

Thanks

[bsalomon, 2014-04-01 11:29:52]

On 2014/04/01 08:36:42, samuelig wrote:
> On 2014/03/25 13:34:55, hcm wrote:
> > On 2014/03/25 13:32:31, bsalomon wrote:
> > > On 2014/03/25 13:30:57, hcm wrote:
> > > > On 2014/03/25 13:19:41, bsalomon wrote:
> > > > > The change looks fine but there are two issues:
> > > > > 
> > > > > 1) I think you need to sign a license agreement form to be added to
the
> > > > authors
> > > > > file, and
> > > > > 
> > > > > 2) I would guess that Chromium or Blink uses the old spelling and we
may
> > > need
> > > > to
> > > > > temporarily alias the factory function name until that code is also
> > updated.
> > > > > 
> > > > > I added hcm@ for details on the first and sugoi@ for the second.
> > > > 
> > > > If you are contributing on behalf of Igalia, I've confirmed they have
> signed
> > > the
> > > > Google Corporate CLA.  We just need you to add a line to the Skia
> > > trunk/AUTHORS
> > > > file for Igalia.  That change can be added to this CL and the commit
check
> > > > should work.
> > > 
> > > Oh great, that line is already in the changelist. So we're good on that
> front.
> > 
> > Yep, didn't see that- looks great!
> 
> Is there any news on the Chromium/Blink side? Shall I update the patch with
the
> alias?
> 
> Thanks

It looks like there is one reference in Blink, so we'll need the alias:

https://code.google.com/p/chromium/codesearch#search/&q=Tubulence&sq=package:...

[siglesias, 2014-04-01 13:31:02]

Added alias

[bsalomon, 2014-04-01 13:59:29]

lgtm

[commit-bot: I haz the power, 2014-04-01 13:59:37]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/siglesias@igalia.com/207543008/60001

[commit-bot: I haz the power, 2014-04-01 16:09:48]

Change committed as 14008