Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1924)

Unified Diff: appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

Issue 2075423002: [Findit] Group failures by culprit and send notification to codereview. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Clean up. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
diff --git a/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py b/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
new file mode 100644
index 0000000000000000000000000000000000000000..64b986e43185e7b53617f3b881db7205e67449bb
--- /dev/null
+++ b/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
@@ -0,0 +1,80 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from datetime import datetime
+import logging
+import textwrap
+
+from google.appengine.ext import ndb
+
+from common.git_repository import GitRepository
+from common.http_client_appengine import HttpClientAppengine as HttpClient
+from common.pipeline_wrapper import BasePipeline
+from common.rietveld import Rietveld
+from model import analysis_status as status
+from model.wf_culprit import WfCulprit
+
+
+@ndb.transactional
+def _ShouldSendNotification(
+ master_name, builder_name, build_number, repo_name, revision):
+ """Returns True if a notification for the culprit should be sent."""
+ culprit = (WfCulprit.Get(repo_name, revision) or
+ WfCulprit.Create(repo_name, revision))
+ if [master_name, builder_name, build_number] in culprit.builds:
+ return False
+
+ culprit.builds.append([master_name, builder_name, build_number])
+ # Send notification when the culprit is for 2+ failures in two different
+ # builds to avoid false positive due to flakiness.
+ # TODO(stgao): move to config.
+ should_send = not (culprit.cr_notification_processed or
+ len(culprit.builds) < 2)
+ if should_send:
+ culprit.cr_notification_status = status.RUNNING
+ culprit.put()
+ return should_send
+
+
+@ndb.transactional
+def _UpdateNotificationStatus(repo_name, revision, new_status):
+ culprit = WfCulprit.Get(repo_name, revision)
+ culprit.cr_notification_status = new_status
+ if culprit.cr_notified:
+ culprit.cr_notification_time = datetime.utcnow()
+ culprit.put()
+
+
+def _SendNotificationForCulprit(repo_name, revision):
+ # TODO(stgao): get repo url at runtime based on the given repo name.
+ repo = GitRepository(
+ 'https://chromium.googlesource.com/chromium/src.git', HttpClient())
+ change_log = repo.GetChangeLog(revision)
+ sent = False
+ if change_log.code_review_url:
+ # Occasionally, a commit was not uploaded for code-review.
+ culprit = WfCulprit.Get(repo_name, revision)
+ rietveld = Rietveld()
+ message = textwrap.dedent("""
+ Findit Try-job identified this CL (revision %s) as the culprit for failures
+ in the build cycle(s) as shown on:
+ https://findit-for-me.appspot.com/waterfall/culprit?key=%s
+ """) % (revision, culprit.key.urlsafe())
+ sent = rietveld.PostMessage(change_log.code_review_url, message)
+ else:
+ logging.error('Can not get code-review url for %s/%s', repo_name, revision)
+
+ _UpdateNotificationStatus(repo_name, revision,
+ status.COMPLETED if sent else status.ERROR)
+ return sent
+
+
+class SendNotificationForCulpritPipeline(BasePipeline):
+
+ # Arguments number differs from overridden method - pylint: disable=W0221
+ def run(self, master_name, builder_name, build_number, repo_name, revision):
+ if not _ShouldSendNotification(
+ master_name, builder_name, build_number, repo_name, revision):
+ return False
+ return _SendNotificationForCulprit(repo_name, revision)

Powered by Google App Engine
This is Rietveld 408576698