Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2075323002: MD Settings: add escape hatch (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 6 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add escape hatch This is in the form of an [annoying, closeable] banner that helps users: 1) file bugs about the new, MD settings UI (bit.ly/md-settings-bug) 2) escape back to old settings (chrome://settings-frame) R=groby@chromium.org BUG=619715 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/27ab53523514b2371ca2343dd0b3f2b1ac0533fc Cr-Commit-Position: refs/heads/master@{#400560}

Patch Set 1 : tweaks #

Total comments: 4

Patch Set 2 : goo.gl #

Patch Set 3 : add localStorage option #

Patch Set 4 : boolify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings.html View 1 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings.js View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Dan Beam
4 years, 6 months ago (2016-06-17 23:07:30 UTC) #3
groby-ooo-7-16
LGTM w/ conspiracy nit. https://codereview.chromium.org/2075323002/diff/20001/chrome/browser/resources/settings/settings.html File chrome/browser/resources/settings/settings.html (right): https://codereview.chromium.org/2075323002/diff/20001/chrome/browser/resources/settings/settings.html#newcode60 chrome/browser/resources/settings/settings.html:60: <a href="https://bit.ly/md-settings-bug">Please file bugs</a> Please ...
4 years, 6 months ago (2016-06-18 00:04:39 UTC) #6
Dan Beam
https://codereview.chromium.org/2075323002/diff/20001/chrome/browser/resources/settings/settings.html File chrome/browser/resources/settings/settings.html (right): https://codereview.chromium.org/2075323002/diff/20001/chrome/browser/resources/settings/settings.html#newcode60 chrome/browser/resources/settings/settings.html:60: <a href="https://bit.ly/md-settings-bug">Please file bugs</a> On 2016/06/18 00:04:39, groby wrote: ...
4 years, 6 months ago (2016-06-18 00:15:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075323002/80001
4 years, 6 months ago (2016-06-18 00:15:57 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 6 months ago (2016-06-18 01:09:48 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 01:10:55 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/27ab53523514b2371ca2343dd0b3f2b1ac0533fc
Cr-Commit-Position: refs/heads/master@{#400560}

Powered by Google App Engine
This is Rietveld 408576698