components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h - Issue 2075313002: Substituting legacy protocol with uWeave protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h

Issue 2075313002: Substituting legacy protocol with uWeave protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unittest memory leak Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc ('k') | components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h

diff --git a/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h b/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h

index 52a3aff3f84285e11192147b94f01412f90f484d..281badff070a9fc5ac95267db8de948f2d1ed480 100644

--- a/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h

+++ b/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h

@@ -27,7 +27,7 @@ class BluetoothLowEnergyWeavePacketGenerator {

NewInstance();

// Exposed for testing.

- static void SetInstanceForTesting(Factory* factory);

+ static void SetInstanceForTesting(std::shared_ptr<Factory> factory);

protected:

// Exposed for testing.

@@ -35,7 +35,7 @@ class BluetoothLowEnergyWeavePacketGenerator {

BuildInstance();

private:

- static Factory* factory_instance_;

+ static std::shared_ptr<Factory> factory_instance_;

};

virtual Packet CreateConnectionRequest();