[DO NOT COMMIT] Initial MediaPlayerRenderer plumbing and basic features

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 65 matching lines @@
 #include "content/public/browser/user_metrics.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/file_chooser_file_info.h"
 #include "content/public/common/file_chooser_params.h"
 #include "content/public/common/isolated_world_ids.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/common/url_utils.h"
 #include "device/vibration/vibration_manager_impl.h"
+// TODO(tguilbert): For reviewers: Is it ok to about include \\media files in
+// this file?
+#include "media/media_features.h"

[xhwang, 2016/06/22 17:39:02]

this is fine. content/ already depends on media/

 #include "ui/accessibility/ax_tree.h"
 #include "ui/accessibility/ax_tree_update.h"
 #include "ui/gfx/geometry/quad_f.h"
 #include "url/gurl.h"
 
 #if defined(OS_ANDROID)
 #include "content/browser/mojo/service_registrar_android.h"
 #endif
 
+#if BUILDFLAG(FORCE_MOJO_MEDIA_PLAYER_RENDERER)
+#include "media/mojo/services/mojo_media_player_renderer_helper.h"
+#endif
+
 #if defined(OS_MACOSX)
 #include "content/browser/frame_host/popup_menu_helper_mac.h"
 #endif
 
 #if defined(ENABLE_WEBVR)
 #include "base/command_line.h"
 #include "content/public/common/content_switches.h"
 #include "device/vr/vr_device_manager.h" // nogncheck
 #endif
 
@@ skipping 1939 matching lines @@
 #if defined(ENABLE_WEBVR)
   const base::CommandLine& browser_command_line =
       *base::CommandLine::ForCurrentProcess();
 
   if (browser_command_line.HasSwitch(switches::kEnableWebVR)) {
     GetServiceRegistry()->AddService<device::VRService>(
         base::Bind(&device::VRDeviceManager::BindRequest));
   }
 #endif
 
+#if BUILDFLAG(FORCE_MOJO_MEDIA_PLAYER_RENDERER)
+  // This service creates a MojoRendererService, passing it a MediaPlayerRender.
+  // TODO(tguilbert): For reviewers: is there a need for disambiguating the
+  // mojom::Renderer service at a RenderFrameHost level?
+  GetServiceRegistry()->AddService<media::mojom::Renderer>(base::Bind(
+      &media::MojoMediaPlayerRendererHelper::CreateMediaPlayerRenderer,

[xhwang, 2016/06/22 17:39:02]

You don't really need a class to do this. You can probably just define a
CreateMediaPlayerRenderer() function, in this file, or in a new media/ file.

+      base::Unretained(this)));
+#endif
+
   GetContentClient()->browser()->RegisterRenderFrameMojoServices(
       GetServiceRegistry(), this);
 }
 
 void RenderFrameHostImpl::ResetWaitingState() {
   DCHECK(is_active());
 
   // The active state of the RVH is determined by its main frame, since
   // subframes should have their own widgets.
   if (frame_tree_node_->IsMainFrame()) {
@@ skipping 842 matching lines @@
   // handler after it's destroyed so it can't run after the RFHI is destroyed.
   web_bluetooth_service_->SetClientConnectionErrorHandler(base::Bind(
       &RenderFrameHostImpl::DeleteWebBluetoothService, base::Unretained(this)));
 }
 
 void RenderFrameHostImpl::DeleteWebBluetoothService() {
   web_bluetooth_service_.reset();
 }
 
 }  // namespace content