Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: gin/v8_initializer.cc

Issue 2075283003: Remove natives_blob.bin's arch dependence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove natives_blob.bin's arch dependence. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/v8_initializer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/v8_initializer.cc
diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc
index deed15188d074685ff0808c90450aa61fa0e05a5..e06c1325290a21935281eab01534e693061f1092 100644
--- a/gin/v8_initializer.cc
+++ b/gin/v8_initializer.cc
@@ -63,22 +63,19 @@ OpenedFileMap::mapped_type& GetOpenedFile(const char* file) {
return opened_files[file];
}
+const char kNativesFileName[] = "natives_blob.bin";
+
#if defined(OS_ANDROID)
-const char kNativesFileName64[] = "natives_blob_64.bin";
const char kSnapshotFileName64[] = "snapshot_blob_64.bin";
-const char kNativesFileName32[] = "natives_blob_32.bin";
const char kSnapshotFileName32[] = "snapshot_blob_32.bin";
#if defined(__LP64__)
-#define kNativesFileName kNativesFileName64
#define kSnapshotFileName kSnapshotFileName64
#else
-#define kNativesFileName kNativesFileName32
#define kSnapshotFileName kSnapshotFileName32
#endif
#else // defined(OS_ANDROID)
-const char kNativesFileName[] = "natives_blob.bin";
const char kSnapshotFileName[] = "snapshot_blob.bin";
#endif // defined(OS_ANDROID)
@@ -388,17 +385,6 @@ base::PlatformFile V8Initializer::GetOpenSnapshotFileForChildProcesses(
#if defined(OS_ANDROID)
// static
-base::PlatformFile V8Initializer::GetOpenNativesFileForChildProcesses(
- base::MemoryMappedFile::Region* region_out,
- bool abi_32_bit) {
- const char* natives_file =
- abi_32_bit ? kNativesFileName32 : kNativesFileName64;
- const OpenedFileMap::mapped_type& opened = OpenFileIfNecessary(natives_file);
- *region_out = opened.second;
- return opened.first;
-}
-
-// static
base::PlatformFile V8Initializer::GetOpenSnapshotFileForChildProcesses(
base::MemoryMappedFile::Region* region_out,
bool abi_32_bit) {
@@ -410,9 +396,9 @@ base::PlatformFile V8Initializer::GetOpenSnapshotFileForChildProcesses(
}
// static
-base::FilePath V8Initializer::GetNativesFilePath(bool abi_32_bit) {
+base::FilePath V8Initializer::GetNativesFilePath() {
base::FilePath path;
- GetV8FilePath(abi_32_bit ? kNativesFileName32 : kNativesFileName64, &path);
+ GetV8FilePath(kNativesFileName, &path);
return path;
}
« no previous file with comments | « gin/v8_initializer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698