Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: content/browser/download/docs/save-page-as.md

Issue 2075273002: Resource requests from Save-Page-As should go through CanRequestURL checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace MarkAsUnauthorized with constructor argument. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/save_page/unauthorized-access.htm ('k') | content/browser/download/save_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/docs/save-page-as.md
diff --git a/content/browser/download/docs/save-page-as.md b/content/browser/download/docs/save-page-as.md
index dba234c6425988540281f70b682e09b57ac0b9b5..a4b6fd240711542e84c13f9cf137acac4a2120ee 100644
--- a/content/browser/download/docs/save-page-as.md
+++ b/content/browser/download/docs/save-page-as.md
@@ -16,10 +16,9 @@ are described by their code comments or by their code structure).
* UI-thread object
* SaveFileCreateInfo::SaveFileSource enum
- * classifies `SaveItem` and `SaveFile` processing into 3 flavours:
+ * classifies `SaveItem` and `SaveFile` processing into 2 flavours:
* `SAVE_FILE_FROM_NET` (see `SaveFileResourceHandler`)
* `SAVE_FILE_FROM_DOM` (see "Complete HTML" section below)
- * `SAVE_FILE_FROM_FILE` (see `SaveFileManager::SaveLocalFile`)
* SaveItem class
* tracks saving a single file
@@ -68,8 +67,8 @@ Very high-level flow of saving a page as "Complete HTML":
* Step 1: `SavePackage` asks all frames for "savable resources"
and creates `SaveItem` for each of files that need to be saved
-* Step 2: `SavePackage` first processes `SAVE_FILE_FROM_NET` and
- `SAVE_FILE_FROM_FILE` `SaveItem`s and asks `SaveFileManager` to save
+* Step 2: `SavePackage` first processes `SAVE_FILE_FROM_NET`
+ `SaveItem`s and asks `SaveFileManager` to save
them.
* Step 3: `SavePackage` handles remaining `SAVE_FILE_FROM_DOM` `SaveItem`s and
@@ -109,8 +108,8 @@ changed using `--save-page-as-mhtml` command line switch.
Very high-level flow of saving a page as "HTML Only":
-* `SavePackage` creates only a single `SaveItem` (either `SAVE_FILE_FROM_NET` or
- `SAVE_FILE_FROM_FILE`) and asks `SaveFileManager` to process it
+* `SavePackage` creates only a single `SaveItem` (always `SAVE_FILE_FROM_NET`)
+ and asks `SaveFileManager` to process it
(as in the Complete HTML individual SaveItem handling above.).
« no previous file with comments | « chrome/test/data/save_page/unauthorized-access.htm ('k') | content/browser/download/save_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698