content/browser/download/docs/save-page-as.md - Issue 2075273002: Resource requests from Save-Page-As should go through CanRequestURL checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/docs/save-page-as.md

Issue 2075273002: Resource requests from Save-Page-As should go through CanRequestURL checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing... Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/save_page/unauthorized-access.htm ('k') | content/browser/download/save_file_manager.cc » ('j') | content/browser/download/save_file_resource_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/docs/save-page-as.md

diff --git a/content/browser/download/docs/save-page-as.md b/content/browser/download/docs/save-page-as.md

index dba234c6425988540281f70b682e09b57ac0b9b5..a4b6fd240711542e84c13f9cf137acac4a2120ee 100644

--- a/content/browser/download/docs/save-page-as.md

+++ b/content/browser/download/docs/save-page-as.md

@@ -16,10 +16,9 @@ are described by their code comments or by their code structure).

* UI-thread object

* SaveFileCreateInfo::SaveFileSource enum

- * classifies `SaveItem` and `SaveFile` processing into 3 flavours:

+ * classifies `SaveItem` and `SaveFile` processing into 2 flavours:

* `SAVE_FILE_FROM_NET` (see `SaveFileResourceHandler`)

* `SAVE_FILE_FROM_DOM` (see "Complete HTML" section below)

- * `SAVE_FILE_FROM_FILE` (see `SaveFileManager::SaveLocalFile`)

* SaveItem class

* tracks saving a single file

@@ -68,8 +67,8 @@ Very high-level flow of saving a page as "Complete HTML":

* Step 1: `SavePackage` asks all frames for "savable resources"

and creates `SaveItem` for each of files that need to be saved

-* Step 2: `SavePackage` first processes `SAVE_FILE_FROM_NET` and

- `SAVE_FILE_FROM_FILE` `SaveItem`s and asks `SaveFileManager` to save

+* Step 2: `SavePackage` first processes `SAVE_FILE_FROM_NET`

+ `SaveItem`s and asks `SaveFileManager` to save

them.

* Step 3: `SavePackage` handles remaining `SAVE_FILE_FROM_DOM` `SaveItem`s and

@@ -109,8 +108,8 @@ changed using `--save-page-as-mhtml` command line switch.

Very high-level flow of saving a page as "HTML Only":

-* `SavePackage` creates only a single `SaveItem` (either `SAVE_FILE_FROM_NET` or

- `SAVE_FILE_FROM_FILE`) and asks `SaveFileManager` to process it

+* `SavePackage` creates only a single `SaveItem` (always `SAVE_FILE_FROM_NET`)

+ and asks `SaveFileManager` to process it

(as in the Complete HTML individual SaveItem handling above.).