Resource requests from Save-Page-As should go through CanRequestURL checks.

content/browser/download/docs/save-page-as.md

Index: content/browser/download/docs/save-page-as.md
diff --git a/content/browser/download/docs/save-page-as.md b/content/browser/download/docs/save-page-as.md
index 2661289b375a9b6a190bc0b5b75529c1acdb02fa..bd93e6cee4302d007b9ee7655e35ef0d42325ce2 100644
--- a/content/browser/download/docs/save-page-as.md
+++ b/content/browser/download/docs/save-page-as.md
@@ -16,10 +16,9 @@ are described by their code comments or by their code structure).
     * UI-thread object
 
 * SaveFileCreateInfo::SaveFileSource enum
-    * classifies `SaveItem` and `SaveFile` processing into 3 flavours:
+    * classifies `SaveItem` and `SaveFile` processing into 2 flavours:
         * `SAVE_FILE_FROM_NET` (see `SaveFileResourceHandler`)
         * `SAVE_FILE_FROM_DOM` (see "Complete HTML" section below)
-        * `SAVE_FILE_FROM_FILE` (see `SaveFileManager::SaveLocalFile`)
 
 * SaveItem class
     * tracks saving a single file
@@ -68,8 +67,8 @@ Very high-level flow of saving a page as "Complete HTML":
 * Step 1: `SavePackage` asks all frames for "savable resources"
           and creates `SaveItem` for each of files that need to be saved
 
-* Step 2: `SavePackage` first processes `SAVE_FILE_FROM_NET` and
-          `SAVE_FILE_FROM_FILE` `SaveItem`s and asks `SaveFileManager` to save
+* Step 2: `SavePackage` first processes `SAVE_FILE_FROM_NET`

[Randy Smith (Not in Mondays), 2016/07/21 19:29:54]

Worth changing the enum name now that it's no-longer making a distinction with
local files?

[Łukasz Anforowicz, 2016/07/21 23:44:30]

Maybe.  I cannot think of a better name.  The gist here is that
SAVE_FILE_FROM_NET save items are saved via a new resource request (which can
come from the net, but we hope it will come from in-memory cache).

Some name ideas that I don't like:

- SAVE_FILE_VIA_RESOURCE_REQUEST - it misses "FROM", so seems like a bad name
for a SaveFile*Source* enum.

- SAVE_FILE_FROM_RESOURCE_REQUEST - this seems confusing / I am not sure what it
means to save something "from" a resource request

I think that SAVE_FILE_FROM_NET is okay, even with the changes (because resource
requests are a concept from the //net layer).  WDYT?

+          `SaveItem`s and asks `SaveFileManager` to save
           them.
 
 * Step 3: `SavePackage` handles remaining `SAVE_FILE_FROM_DOM` `SaveItem`s and
@@ -106,8 +105,8 @@ changed using `--save-page-as-mhtml` command line switch.
 
 Very high-level flow of saving a page as "HTML Only":
 
-* `SavePackage` creates only a single `SaveItem` (either `SAVE_FILE_FROM_NET` or
-  `SAVE_FILE_FROM_FILE`) and asks `SaveFileManager` to process it
+* `SavePackage` creates only a single `SaveItem` (always `SAVE_FILE_FROM_NET`)
+  and asks `SaveFileManager` to process it
   (as in the Complete HTML individual SaveItem handling above.).