Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: content/browser/download/save_file_resource_handler.cc

Issue 2075273002: Resource requests from Save-Page-As should go through CanRequestURL checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace MarkAsUnauthorized with constructor argument. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/download/save_file_resource_handler.h" 5 #include "content/browser/download/save_file_resource_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "content/browser/download/save_file_manager.h" 11 #include "content/browser/download/save_file_manager.h"
12 #include "content/public/browser/browser_thread.h" 12 #include "content/public/browser/browser_thread.h"
13 #include "net/base/io_buffer.h" 13 #include "net/base/io_buffer.h"
14 #include "net/url_request/redirect_info.h" 14 #include "net/url_request/redirect_info.h"
15 #include "net/url_request/url_request_status.h" 15 #include "net/url_request/url_request_status.h"
16 16
17 namespace content { 17 namespace content {
18 18
19 SaveFileResourceHandler::SaveFileResourceHandler(net::URLRequest* request, 19 SaveFileResourceHandler::SaveFileResourceHandler(
20 SaveItemId save_item_id, 20 net::URLRequest* request,
21 SavePackageId save_package_id, 21 SaveItemId save_item_id,
22 int render_process_host_id, 22 SavePackageId save_package_id,
23 int render_frame_routing_id, 23 int render_process_host_id,
24 const GURL& url, 24 int render_frame_routing_id,
25 SaveFileManager* manager) 25 const GURL& url,
26 SaveFileManager* manager,
27 AuthorizationState authorization_state)
26 : ResourceHandler(request), 28 : ResourceHandler(request),
27 save_item_id_(save_item_id), 29 save_item_id_(save_item_id),
28 save_package_id_(save_package_id), 30 save_package_id_(save_package_id),
29 render_process_id_(render_process_host_id), 31 render_process_id_(render_process_host_id),
30 render_frame_routing_id_(render_frame_routing_id), 32 render_frame_routing_id_(render_frame_routing_id),
31 url_(url), 33 url_(url),
32 content_length_(0), 34 content_length_(0),
33 save_manager_(manager) {} 35 save_manager_(manager),
36 authorization_state_(authorization_state) {}
34 37
35 SaveFileResourceHandler::~SaveFileResourceHandler() { 38 SaveFileResourceHandler::~SaveFileResourceHandler() {
36 } 39 }
37 40
38 bool SaveFileResourceHandler::OnRequestRedirected( 41 bool SaveFileResourceHandler::OnRequestRedirected(
39 const net::RedirectInfo& redirect_info, 42 const net::RedirectInfo& redirect_info,
40 ResourceResponse* response, 43 ResourceResponse* response,
41 bool* defer) { 44 bool* defer) {
42 final_url_ = redirect_info.new_url; 45 final_url_ = redirect_info.new_url;
43 return true; 46 return true;
44 } 47 }
45 48
46 bool SaveFileResourceHandler::OnResponseStarted(ResourceResponse* response, 49 bool SaveFileResourceHandler::OnResponseStarted(ResourceResponse* response,
47 bool* defer) { 50 bool* defer) {
48 // |save_manager_| consumes (deletes): 51 // |save_manager_| consumes (deletes):
49 SaveFileCreateInfo* info = new SaveFileCreateInfo( 52 SaveFileCreateInfo* info = new SaveFileCreateInfo(
50 url_, final_url_, save_item_id_, save_package_id_, render_process_id_, 53 url_, final_url_, save_item_id_, save_package_id_, render_process_id_,
51 render_frame_routing_id_, GetRequestID(), content_disposition_, 54 render_frame_routing_id_, GetRequestID(), content_disposition_,
52 content_length_); 55 content_length_);
53 BrowserThread::PostTask( 56 BrowserThread::PostTask(
54 BrowserThread::FILE, FROM_HERE, 57 BrowserThread::FILE, FROM_HERE,
55 base::Bind(&SaveFileManager::StartSave, save_manager_, info)); 58 base::Bind(&SaveFileManager::StartSave, save_manager_, info));
56 return true; 59 return true;
57 } 60 }
58 61
59 bool SaveFileResourceHandler::OnWillStart(const GURL& url, bool* defer) { 62 bool SaveFileResourceHandler::OnWillStart(const GURL& url, bool* defer) {
60 return true; 63 return authorization_state_ == AuthorizationState::AUTHORIZED;
61 } 64 }
62 65
63 bool SaveFileResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf, 66 bool SaveFileResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf,
64 int* buf_size, 67 int* buf_size,
65 int min_size) { 68 int min_size) {
69 DCHECK_EQ(AuthorizationState::AUTHORIZED, authorization_state_);
66 DCHECK(buf && buf_size); 70 DCHECK(buf && buf_size);
67 if (!read_buffer_.get()) { 71 if (!read_buffer_.get()) {
68 *buf_size = min_size < 0 ? kReadBufSize : min_size; 72 *buf_size = min_size < 0 ? kReadBufSize : min_size;
69 read_buffer_ = new net::IOBuffer(*buf_size); 73 read_buffer_ = new net::IOBuffer(*buf_size);
70 } 74 }
71 *buf = read_buffer_.get(); 75 *buf = read_buffer_.get();
72 return true; 76 return true;
73 } 77 }
74 78
75 bool SaveFileResourceHandler::OnReadCompleted(int bytes_read, bool* defer) { 79 bool SaveFileResourceHandler::OnReadCompleted(int bytes_read, bool* defer) {
80 DCHECK_EQ(AuthorizationState::AUTHORIZED, authorization_state_);
76 DCHECK(read_buffer_.get()); 81 DCHECK(read_buffer_.get());
77 // We are passing ownership of this buffer to the save file manager. 82 // We are passing ownership of this buffer to the save file manager.
78 scoped_refptr<net::IOBuffer> buffer; 83 scoped_refptr<net::IOBuffer> buffer;
79 read_buffer_.swap(buffer); 84 read_buffer_.swap(buffer);
80 BrowserThread::PostTask( 85 BrowserThread::PostTask(
81 BrowserThread::FILE, FROM_HERE, 86 BrowserThread::FILE, FROM_HERE,
82 base::Bind(&SaveFileManager::UpdateSaveProgress, save_manager_, 87 base::Bind(&SaveFileManager::UpdateSaveProgress, save_manager_,
83 save_item_id_, base::RetainedRef(buffer), bytes_read)); 88 save_item_id_, base::RetainedRef(buffer), bytes_read));
84 return true; 89 return true;
85 } 90 }
86 91
87 void SaveFileResourceHandler::OnResponseCompleted( 92 void SaveFileResourceHandler::OnResponseCompleted(
88 const net::URLRequestStatus& status, 93 const net::URLRequestStatus& status,
89 const std::string& security_info, 94 const std::string& security_info,
90 bool* defer) { 95 bool* defer) {
96 if (authorization_state_ != AuthorizationState::AUTHORIZED)
97 DCHECK(!status.is_success());
98
91 BrowserThread::PostTask( 99 BrowserThread::PostTask(
92 BrowserThread::FILE, FROM_HERE, 100 BrowserThread::FILE, FROM_HERE,
93 base::Bind(&SaveFileManager::SaveFinished, save_manager_, save_item_id_, 101 base::Bind(&SaveFileManager::SaveFinished, save_manager_, save_item_id_,
94 save_package_id_, 102 save_package_id_,
95 status.is_success() && !status.is_io_pending())); 103 status.is_success() && !status.is_io_pending()));
96 read_buffer_ = NULL; 104 read_buffer_ = NULL;
97 } 105 }
98 106
99 void SaveFileResourceHandler::OnDataDownloaded(int bytes_downloaded) { 107 void SaveFileResourceHandler::OnDataDownloaded(int bytes_downloaded) {
100 NOTREACHED(); 108 NOTREACHED();
101 } 109 }
102 110
103 void SaveFileResourceHandler::set_content_length( 111 void SaveFileResourceHandler::set_content_length(
104 const std::string& content_length) { 112 const std::string& content_length) {
105 base::StringToInt64(content_length, &content_length_); 113 base::StringToInt64(content_length, &content_length_);
106 } 114 }
107 115
108 } // namespace content 116 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/download/save_file_resource_handler.h ('k') | content/browser/download/save_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698