chrome/test/data/save_page/unauthorized-access.htm - Issue 2075273002: Resource requests from Save-Page-As should go through CanRequestURL checks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/save_page/unauthorized-access.htm

Issue 2075273002: Resource requests from Save-Page-As should go through CanRequestURL checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated docs. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/download/save_page_browsertest.cc ('K') | « chrome/test/data/save_page/text.txt ('k') | content/browser/download/docs/save-page-as.md » ('j') | content/browser/download/docs/save-page-as.md » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <title>

	4 Test page for saving page feature

	5 </title>

	6 </head>

	7 <body>

	8 When this page is loaded over HTTP (i.e. via embedded_test_server() from a

	9 browser test), then it should be denied access to local resources, like the

	10 file: URI from the img tag below. This test verifies that access to the

	11 file: URI will also be forbidden when saving all resources of the page

	12 during Save-Page-As-Complete-HTML.

	13 <img id="resource1"

	14 src="file:///path-to-be-set-at-test-runtime/should-not-save.txt"></img>

	15 </body>

	16 </html>

OLD	NEW