Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2075263002: PPC/s390: [builtins] Introduce proper Float64Exp operator. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Introduce proper Float64Exp operator. Port d5f2ac5e3326f281cbe7ba57464a4b17a9938e37 Original commit message: Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.exp() as TurboFan builtin and use that operator to also inline Math.exp() into optimized TurboFan functions. R=bmeurer@chromium.org, mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:3266, v8:3468, v8:3493, v8:5086, v8:5108, chromium:620786 LOG=N Committed: https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb Cr-Commit-Position: refs/heads/master@{#37073}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments, uploaded doubleregister to d0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -371 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 1 chunk +2 lines, -12 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 1 chunk +2 lines, -12 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M src/ppc/codegen-ppc.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 2 chunks +0 lines, -146 lines 0 comments Download
M src/s390/codegen-s390.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/s390/codegen-s390.cc View 2 chunks +0 lines, -139 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-17 21:40:01 UTC) #1
john.yan
Lgtm with one comment. https://codereview.chromium.org/2075263002/diff/1/src/crankshaft/s390/lithium-s390.cc File src/crankshaft/s390/lithium-s390.cc (right): https://codereview.chromium.org/2075263002/diff/1/src/crankshaft/s390/lithium-s390.cc#newcode1050 src/crankshaft/s390/lithium-s390.cc:1050: LOperand* input = UseFixedDouble(instr->value(), d1); ...
4 years, 6 months ago (2016-06-18 02:13:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075263002/20001
4 years, 6 months ago (2016-06-18 04:09:23 UTC) #5
JaideepBajwa
On 2016/06/18 02:13:50, john.yan wrote: > Lgtm with one comment. > > https://codereview.chromium.org/2075263002/diff/1/src/crankshaft/s390/lithium-s390.cc > File ...
4 years, 6 months ago (2016-06-18 04:10:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-18 09:35:54 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 09:38:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb
Cr-Commit-Position: refs/heads/master@{#37073}

Powered by Google App Engine
This is Rietveld 408576698