Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2075213002: Draw nicer arrows when the scrollbar buttons are not square. (Closed)

Created:
4 years, 6 months ago by Bret
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Draw nicer arrows when the scrollbar buttons are not square. Before they would look squished or messed up, but with this patch their bounding box is always square so we'll get the nice pixel pyramids that we want. This shouldn't change anything visually for the normal square scrollbar buttons. BUG=614297 Review-Url: https://codereview.chromium.org/2009733002 Cr-Commit-Position: refs/heads/master@{#399626} (cherry picked from commit 91cbc6d7c2f02771ee3640a4b2f3376029b3bab0) Committed: https://chromium.googlesource.com/chromium/src/+/cf604e6b3f7b8c67b3c1d0c7dbe83a3c174fd21e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -26 lines) Patch
M ui/native_theme/BUILD.gn View 2 chunks +22 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_aura_unittest.cc View 1 chunk +86 lines, -16 lines 0 comments Download
M ui/native_theme/native_theme_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/native_theme/native_theme_base.cc View 5 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Bret
4 years, 6 months ago (2016-06-17 18:49:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cf604e6b3f7b8c67b3c1d0c7dbe83a3c174fd21e.

Powered by Google App Engine
This is Rietveld 408576698