Fixes use-after-free in MojoDemuxerStreamImpl.

media/mojo/clients/mojo_demuxer_stream_impl.h

Index: media/mojo/clients/mojo_demuxer_stream_impl.h
diff --git a/media/mojo/clients/mojo_demuxer_stream_impl.h b/media/mojo/clients/mojo_demuxer_stream_impl.h
index 0d3794897cbf125430187a6820e480af4154a58f..49d97b716ecc659b909ffe339b968e0b2b56764b 100644
--- a/media/mojo/clients/mojo_demuxer_stream_impl.h
+++ b/media/mojo/clients/mojo_demuxer_stream_impl.h
@@ -9,7 +9,7 @@
 #include "base/memory/weak_ptr.h"
 #include "media/base/demuxer_stream.h"
 #include "media/mojo/interfaces/demuxer_stream.mojom.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "mojo/public/cpp/bindings/binding.h"
 
 namespace media {
 class DemuxerStream;
@@ -31,12 +31,18 @@ class MojoDemuxerStreamImpl : public mojom::DemuxerStream {
   void Read(const ReadCallback& callback) override;
   void EnableBitstreamConverter() override;
 
+  // Sets an error handler that will be called if a connection error occurs on
+  // the bound message pipe.
+  void set_connection_error_handler(const mojo::Closure& error_handler) {
+    binding_.set_connection_error_handler(error_handler);
+  }
+
  private:
   void OnBufferReady(const ReadCallback& callback,
                      media::DemuxerStream::Status status,
                      const scoped_refptr<media::DecoderBuffer>& buffer);
 
-  mojo::StrongBinding<mojom::DemuxerStream> binding_;
+  mojo::Binding<mojom::DemuxerStream> binding_;

[Ken Rockot(use gerrit already), 2016/06/19 14:45:22]

Some tests now leak a MojoDemxuerStreamImpl:
https://cs.chromium.org/chromium/src/media/mojo/services/media_mojo_unittest....

[alokp, 2016/06/20 16:44:48]

Memory leak fix here: https://codereview.chromium.org/2087473002/

Out of curiosity, how did you discover the memory leak? Did it trigger any
memory bot failure? I do not see any failure on the bots.

 
   // See constructor.  We do not own |stream_|.
   media::DemuxerStream* stream_;