Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2075133003: Respect color type and gamma settings in nanobench GPU configs (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Respect color type and gamma settings in nanobench GPU configs We were ignoring the requested properties in things like gpuf16 and gpusrgb. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075133003 Committed: https://skia.googlesource.com/skia/+/1a48e13303ec58ea2c6411651f19baf765b66651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M bench/nanobench.cpp View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075133003/1
4 years, 6 months ago (2016-06-17 15:33:32 UTC) #3
Brian Osman
We don't run these configs on the bots yet, but I'd like to.
4 years, 6 months ago (2016-06-17 15:34:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 15:46:07 UTC) #7
bsalomon
lgtm
4 years, 6 months ago (2016-06-20 16:21:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075133003/1
4 years, 6 months ago (2016-06-20 16:26:12 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 16:41:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1a48e13303ec58ea2c6411651f19baf765b66651

Powered by Google App Engine
This is Rietveld 408576698