Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2075133002: Don't try to set gamma treatment if texture creation fails. (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't try to set gamma treatment if texture creation fails. Guessing this will fix the valgrind failure. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075133002 Committed: https://skia.googlesource.com/skia/+/7d2f607ac16788eac985d4738b8cb901971f33c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/gpu/SkGr.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075133002/1
4 years, 6 months ago (2016-06-17 13:42:36 UTC) #3
Brian Osman
Waiting for trybot to verify the fix, but I'm hopeful.
4 years, 6 months ago (2016-06-17 13:56:16 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 13:58:09 UTC) #7
egdaniel
lgtm
4 years, 6 months ago (2016-06-17 14:00:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075133002/1
4 years, 6 months ago (2016-06-17 14:02:51 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 14:03:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7d2f607ac16788eac985d4738b8cb901971f33c3

Powered by Google App Engine
This is Rietveld 408576698