Chromium Code Reviews
DescriptionRevert of Use an explicit list of webkit-patch commands instead of using auto-discovery. (patchset #2 id:20001 of https://codereview.chromium.org/2070333003/ )
Reason for revert:
Broke rebaseline-o-matic because commands are not bound to tool.
Original issue's description:
> Use an explicit list of webkit-patch commands instead of using auto-discovery.
>
> This is a followup to http://crrev.com/1950773002 and related CLs,
> which removed remove imports from other __init__.py files; after this,
> all of the __init__.py files in webkitpy are empty.
>
> Before this CL, webkit-patch relies on all commands being imported (by
> importing the package webkitpy.tool.commands) and then discovering all
> subclasses of command using the magic method __subclasses__.
>
> This CL makes it so that commands that are part of webkit-patch are
> explicitly listed, and there is no class discovery.
>
> BUG=598897
>
> Committed: https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2
> Cr-Commit-Position: refs/heads/master@{#400369}
TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598897
Committed: https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e
Cr-Commit-Position: refs/heads/master@{#400376}
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||