Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2075073002: Revert of Use an explicit list of webkit-patch commands instead of using auto-discovery. (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, qyearsley
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use an explicit list of webkit-patch commands instead of using auto-discovery. (patchset #2 id:20001 of https://codereview.chromium.org/2070333003/ ) Reason for revert: Broke rebaseline-o-matic because commands are not bound to tool. Original issue's description: > Use an explicit list of webkit-patch commands instead of using auto-discovery. > > This is a followup to http://crrev.com/1950773002 and related CLs, > which removed remove imports from other __init__.py files; after this, > all of the __init__.py files in webkitpy are empty. > > Before this CL, webkit-patch relies on all commands being imported (by > importing the package webkitpy.tool.commands) and then discovering all > subclasses of command using the magic method __subclasses__. > > This CL makes it so that commands that are part of webkit-patch are > explicitly listed, and there is no class discovery. > > BUG=598897 > > Committed: https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2 > Cr-Commit-Position: refs/heads/master@{#400369} TBR=dpranke@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598897 Committed: https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e Cr-Commit-Position: refs/heads/master@{#400376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -39 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool.py View 2 chunks +17 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py View 2 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Xianzhu
Created Revert of Use an explicit list of webkit-patch commands instead of using auto-discovery.
4 years, 6 months ago (2016-06-17 06:17:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075073002/1
4 years, 6 months ago (2016-06-17 06:17:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 06:18:22 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e Cr-Commit-Position: refs/heads/master@{#400376}
4 years, 6 months ago (2016-06-17 06:21:01 UTC) #6
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-17 15:55:08 UTC) #7
qyearsley
4 years, 6 months ago (2016-06-17 16:19:22 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2073893004/ by qyearsley@chromium.org.

The reason for reverting is: I believe the problem was that the commands weren't
passed to the MultiCommandTool constructor, so
command.bind_to_tool(multi_command_tool) wasn't called for the commands..

Powered by Google App Engine
This is Rietveld 408576698