Make SdchDictionaryFetcher free more memory when done.

net/url_request/sdch_dictionary_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/sdch_dictionary_fetcher.h"
 
 #include <stdint.h>
 #include <queue>
 #include <set>
 
@@ skipping 207 matching lines @@
   // and Schedule() is only called from user code, so this call to DoLoop()
   // does not require an |if (in_loop_) return;| guard.
   DoLoop(OK);
   return true;
 }
 
 void SdchDictionaryFetcher::ResetRequest() {
   current_request_.reset();
   buffer_ = nullptr;
   current_callback_.Reset();
-  dictionary_.clear();
+  dictionary_.reset();
   return;
 }
 
 int SdchDictionaryFetcher::DoLoop(int rv) {
   DCHECK(!in_loop_);
   base::AutoReset<bool> auto_reset_in_loop(&in_loop_, true);
 
   do {
     State state = next_state_;
     next_state_ = STATE_NONE;
@@ skipping 40 matching lines @@
   FetchInfo info;
   bool success = fetch_queue_->Pop(&info);
   DCHECK(success);
   current_request_ = context_->CreateRequest(info.url, IDLE, this);
   int load_flags = LOAD_DO_NOT_SEND_COOKIES | LOAD_DO_NOT_SAVE_COOKIES;
   if (info.cache_only)
     load_flags |= LOAD_ONLY_FROM_CACHE;
   current_request_->SetLoadFlags(load_flags);
 
   buffer_ = new IOBuffer(kBufferSize);
+  dictionary_.reset(new std::string());
   current_callback_ = info.callback;
 
   current_request_->Start();
   current_request_->net_log().AddEvent(NetLog::TYPE_SDCH_DICTIONARY_FETCH);
 
   return ERR_IO_PENDING;
 }
 
 int SdchDictionaryFetcher::DoReceivedRedirect(int rv) {
   // Fetching SDCH through a redirect is forbidden; it raises possible
@@ skipping 44 matching lines @@
   if (rv < 0) {
     ResetRequest();
     next_state_ = STATE_SEND_REQUEST;
     return OK;
   }
 
   DCHECK(current_request_->status().is_success());
 
   // Data; append to the dictionary and look for more data.
   if (rv > 0) {
-    dictionary_.append(buffer_->data(), rv);
+    dictionary_->append(buffer_->data(), rv);
     next_state_ = STATE_READ_BODY;
     return OK;
   }
 
   // End of file; complete the request.
   next_state_ = STATE_REQUEST_COMPLETE;
   return OK;
 }
 
 int SdchDictionaryFetcher::DoCompleteRequest(int rv) {
   DCHECK(CalledOnValidThread());
 
   // If the dictionary was successfully fetched, add it to the manager.
   if (rv == OK) {
-    current_callback_.Run(dictionary_, current_request_->url(),
+    current_callback_.Run(*dictionary_, current_request_->url(),
                           current_request_->net_log(),
                           current_request_->was_cached());
   }
 
   ResetRequest();
   next_state_ = STATE_SEND_REQUEST;
   return OK;
 }
 
 }  // namespace net