Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: content/child/webfileutilities_impl.cc

Issue 207503002: Remove PlatformFile from WebFileUtilitiesImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove methods Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/child/webfileutilities_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/webfileutilities_impl.h" 5 #include "content/child/webfileutilities_impl.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "content/child/blink_glue.h" 10 #include "content/child/blink_glue.h"
(...skipping 13 matching lines...) Expand all
24 24
25 WebFileUtilitiesImpl::~WebFileUtilitiesImpl() { 25 WebFileUtilitiesImpl::~WebFileUtilitiesImpl() {
26 } 26 }
27 27
28 bool WebFileUtilitiesImpl::getFileInfo(const WebString& path, 28 bool WebFileUtilitiesImpl::getFileInfo(const WebString& path,
29 blink::WebFileInfo& web_file_info) { 29 blink::WebFileInfo& web_file_info) {
30 if (sandbox_enabled_) { 30 if (sandbox_enabled_) {
31 NOTREACHED(); 31 NOTREACHED();
32 return false; 32 return false;
33 } 33 }
34 // TODO(rvargas): convert this code to use base::File::Info.
35 base::File::Info file_info; 34 base::File::Info file_info;
36 if (!base::GetFileInfo(base::FilePath::FromUTF16Unsafe(path), 35 if (!base::GetFileInfo(base::FilePath::FromUTF16Unsafe(path),
37 reinterpret_cast<base::File::Info*>(&file_info))) 36 reinterpret_cast<base::File::Info*>(&file_info)))
38 return false; 37 return false;
39 38
40 FileInfoToWebFileInfo(file_info, &web_file_info); 39 FileInfoToWebFileInfo(file_info, &web_file_info);
41 web_file_info.platformPath = path; 40 web_file_info.platformPath = path;
42 return true; 41 return true;
43 } 42 }
44 43
45 WebString WebFileUtilitiesImpl::directoryName(const WebString& path) { 44 WebString WebFileUtilitiesImpl::directoryName(const WebString& path) {
46 return base::FilePath::FromUTF16Unsafe(path).DirName().AsUTF16Unsafe(); 45 return base::FilePath::FromUTF16Unsafe(path).DirName().AsUTF16Unsafe();
47 } 46 }
48 47
49 WebString WebFileUtilitiesImpl::baseName(const WebString& path) { 48 WebString WebFileUtilitiesImpl::baseName(const WebString& path) {
50 return base::FilePath::FromUTF16Unsafe(path).BaseName().AsUTF16Unsafe(); 49 return base::FilePath::FromUTF16Unsafe(path).BaseName().AsUTF16Unsafe();
51 } 50 }
52 51
53 blink::WebURL WebFileUtilitiesImpl::filePathToURL(const WebString& path) { 52 blink::WebURL WebFileUtilitiesImpl::filePathToURL(const WebString& path) {
54 return net::FilePathToFileURL(base::FilePath::FromUTF16Unsafe(path)); 53 return net::FilePathToFileURL(base::FilePath::FromUTF16Unsafe(path));
55 } 54 }
56 55
57 base::PlatformFile WebFileUtilitiesImpl::openFile(const WebString& path,
58 int mode) {
59 if (sandbox_enabled_) {
60 NOTREACHED();
61 return base::kInvalidPlatformFileValue;
62 }
63 // mode==0 (read-only) is the only supported mode.
64 // TODO(kinuko): Remove this parameter.
65 DCHECK_EQ(0, mode);
66 return base::CreatePlatformFile(
67 base::FilePath::FromUTF16Unsafe(path),
68 base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ,
69 NULL, NULL);
70 }
71
72 void WebFileUtilitiesImpl::closeFile(base::PlatformFile& handle) {
73 if (handle == base::kInvalidPlatformFileValue)
74 return;
75 if (base::ClosePlatformFile(handle))
76 handle = base::kInvalidPlatformFileValue;
77 }
78
79 int WebFileUtilitiesImpl::readFromFile(base::PlatformFile handle,
80 char* data,
81 int length) {
82 if (handle == base::kInvalidPlatformFileValue || !data || length <= 0)
83 return -1;
84 return base::ReadPlatformFileCurPosNoBestEffort(handle, data, length);
85 }
86
87 } // namespace content 56 } // namespace content
OLDNEW
« no previous file with comments | « content/child/webfileutilities_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698