Remove PlatformFile from WebFileUtilitiesImpl

Remove PlatformFile from WebFileUtilitiesImpl

BUG=322664
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259461

[rvargas (doing something else), 2014-03-21 18:39:16]

PTAL

https://codereview.chromium.org/207503002/diff/1/content/child/webfileutiliti...
File content/child/webfileutilities_impl.cc (right):

https://codereview.chromium.org/207503002/diff/1/content/child/webfileutiliti...
content/child/webfileutilities_impl.cc:65: int
WebFileUtilitiesImpl::readFromFile(base::File* file,
I would actually remove this method completely, as the caller already has a File
and can just use it.

[kinuko, 2014-03-24 09:45:39]

https://codereview.chromium.org/207503002/diff/1/content/child/webfileutiliti...
File content/child/webfileutilities_impl.h (right):

https://codereview.chromium.org/207503002/diff/1/content/child/webfileutiliti...
content/child/webfileutilities_impl.h:27: virtual base::File openFile(const
blink::WebString& path);
Um... I guess we could likely just remove these two methods?

I think it's a remnant from crbug.com/267341

[rvargas (doing something else), 2014-03-24 22:15:52]

Thanks

https://codereview.chromium.org/207503002/diff/1/content/child/webfileutiliti...
File content/child/webfileutilities_impl.h (right):

https://codereview.chromium.org/207503002/diff/1/content/child/webfileutiliti...
content/child/webfileutilities_impl.h:27: virtual base::File openFile(const
blink::WebString& path);
On 2014/03/24 09:45:39, kinuko wrote:
> Um... I guess we could likely just remove these two methods?
> 
> I think it's a remnant from crbug.com/267341

OK. They are not used but I though they were going to be used :)

[kinuko, 2014-03-25 03:00:22]

On 2014/03/24 22:15:52, rvargas wrote:
> Thanks
> 
>
https://codereview.chromium.org/207503002/diff/1/content/child/webfileutiliti...
> File content/child/webfileutilities_impl.h (right):
> 
>
https://codereview.chromium.org/207503002/diff/1/content/child/webfileutiliti...
> content/child/webfileutilities_impl.h:27: virtual base::File openFile(const
> blink::WebString& path);
> On 2014/03/24 09:45:39, kinuko wrote:
> > Um... I guess we could likely just remove these two methods?
> > 
> > I think it's a remnant from crbug.com/267341
> 
> OK. They are not used but I though they were going to be used :)

Thanks, lgtm!

[rvargas (doing something else), 2014-03-25 03:06:32]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-03-25 03:06:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rvargas@chromium.org/207503002/20001

[commit-bot: I haz the power, 2014-03-25 03:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 03:45:09]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[rvargas (doing something else), 2014-03-25 19:13:29]

+jam for owners

[jam, 2014-03-25 22:51:39]

lgtm

[rvargas (doing something else), 2014-03-26 00:19:07]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-03-26 00:19:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rvargas@chromium.org/207503002/20001

[commit-bot: I haz the power, 2014-03-26 03:58:10]

Change committed as 259461