MD History: show and hide search spinner and icon the same way

MD History: show and hide search spinner and icon the same way

R=tsergeant@chromium.org
BUG=620910
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/bcb81706c2577bcee91c9056be3d26cae373830f
Cr-Commit-Position: refs/heads/master@{#402922}

[Dan Beam, 2016-06-16 23:24:27]

Description was changed from

==========
MD History: show and hide search spinner and icon the same way

R=tsergeant@chromium.org
BUG=620910
==========

to

==========
MD History: show and hide search spinner and icon the same way

R=tsergeant@chromium.org
BUG=620910
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-06-16 23:25:35]

this change also smooths out short searchs by not showing a twitchy spinner

https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
(left):

https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:34:
transition: opacity 150ms;
#icon's visibility change was effectively taking 150ms, whereas the spinner was
immediate

[tsergeant, 2016-06-17 00:23:39]

On 2016/06/16 23:25:35, Dan Beam wrote:
> this change also smooths out short searchs by not showing a twitchy spinner
> 
>
https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_eleme...
> File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
> (left):
> 
>
https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_eleme...
> ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:34:
> transition: opacity 150ms;
> #icon's visibility change was effectively taking 150ms, whereas the spinner
was
> immediate

I'm not sure I see the improvement locally? paper-spinner has a built in
fade-out animation which looks pretty smooth. With this change, the spinner
disappears quite abruptly when it becomes inactive. Here's a gif of what I'm
seeing: http://i.imgur.com/4oriBIu.gif

[tsergeant, 2016-06-29 04:06:37]

Cool, this seems to help the local-only search a lot.

lgtm

https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
(right):

https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:38:
transition: opacity 150ms;
Maybe increase this to 200 or 250ms to smooth out the animation a bit more? It
looks a bit abrupt to me at 150ms (when signed in, doing a search that takes
more than half a second).

[Dan Beam, 2016-06-29 19:22:28]

https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
(right):

https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:38:
transition: opacity 150ms;
On 2016/06/29 04:06:37, tsergeant wrote:
> Maybe increase this to 200 or 250ms to smooth out the animation a bit more? It
> looks a bit abrupt to me at 150ms (when signed in, doing a search that takes
> more than half a second).

upped to 200, feel free to tweak

[Dan Beam, 2016-06-29 19:23:42]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-06-29 19:23:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2075013002/#ps20001
(title: "asdf")

[commit-bot: I haz the power, 2016-06-29 19:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 20:18:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 20:19:43]

Description was changed from

==========
MD History: show and hide search spinner and icon the same way

R=tsergeant@chromium.org
BUG=620910
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: show and hide search spinner and icon the same way

R=tsergeant@chromium.org
BUG=620910
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/bcb81706c2577bcee91c9056be3d26cae373830f
Cr-Commit-Position: refs/heads/master@{#402922}
==========

[commit-bot: I haz the power, 2016-06-29 20:19:44]

Patchset 2 (id:??) landed as
https://crrev.com/bcb81706c2577bcee91c9056be3d26cae373830f
Cr-Commit-Position: refs/heads/master@{#402922}