Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2075013002: MD History: show and hide search spinner and icon the same way (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: show and hide search spinner and icon the same way R=tsergeant@chromium.org BUG=620910 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bcb81706c2577bcee91c9056be3d26cae373830f Cr-Commit-Position: refs/heads/master@{#402922}

Patch Set 1 #

Total comments: 3

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Dan Beam
this change also smooths out short searchs by not showing a twitchy spinner https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html File ...
4 years, 6 months ago (2016-06-16 23:25:35 UTC) #2
tsergeant
On 2016/06/16 23:25:35, Dan Beam wrote: > this change also smooths out short searchs by ...
4 years, 6 months ago (2016-06-17 00:23:39 UTC) #3
tsergeant
Cool, this seems to help the local-only search a lot. lgtm https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): ...
4 years, 5 months ago (2016-06-29 04:06:37 UTC) #4
Dan Beam
https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html (right): https://codereview.chromium.org/2075013002/diff/1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html#newcode38 ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html:38: transition: opacity 150ms; On 2016/06/29 04:06:37, tsergeant wrote: > ...
4 years, 5 months ago (2016-06-29 19:22:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2075013002/20001
4 years, 5 months ago (2016-06-29 19:24:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 20:18:17 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 20:19:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bcb81706c2577bcee91c9056be3d26cae373830f
Cr-Commit-Position: refs/heads/master@{#402922}

Powered by Google App Engine
This is Rietveld 408576698