Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2075003003: Reland of move WorkerBackingThread::scriptCount (Closed)

Created:
4 years, 6 months ago by Henrik Grunell
Modified:
4 years, 6 months ago
Reviewers:
flackr, nhiroki, yhirano
CC:
chromium-reviews, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move WorkerBackingThread::scriptCount (patchset #1 id:1 of https://codereview.chromium.org/2066403003/ ) Reason for revert: The reverted CL was not the cause of the failure, so I'm reverting the revert. Original issue's description: > Revert of Remove WorkerBackingThread::scriptCount (patchset #3 id:80001 of https://codereview.chromium.org/2053273002/ ) > > Reason for revert: > Two compositorworker tests have failed flakily after this change: > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24612 > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24613 > > Original issue's description: > > Remove WorkerBackingThread::scriptCount > > > > This CL removes scriptCount from WorkerBackingThread. The count was > > needed for compositor workers, but we don't need it any more because > > of compositor workers' design change. > > > > Before this change, compositor workers are exempted from > > TerminateExecution call because multiple workers can share the same > > backing thread, but with this change TerminateExecution can be > > called for a compositor worker when it doesn't start the shutdown > > sequence in a timely manner. > > > > BUG=487050 > > > > Committed: https://crrev.com/17686215e73797de165dd749f8f77d1388f1ede6 > > Cr-Commit-Position: refs/heads/master@{#400102} > > TBR=nhiroki@chromium.org,flackr@chromium.org,yhirano@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=487050 > > Committed: https://crrev.com/bba247eab1816bc571d46f41de6346c3b7fbbfa6 > Cr-Commit-Position: refs/heads/master@{#400133} TBR=nhiroki@chromium.org,flackr@chromium.org,yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=487050 Committed: https://crrev.com/cb73cd4e09dd03434c0d837aefa3dcf7ef2137e9 Cr-Commit-Position: refs/heads/master@{#400413}

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
Henrik Grunell
Created Reland of move WorkerBackingThread::scriptCount
4 years, 6 months ago (2016-06-17 10:02:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075003003/1
4 years, 6 months ago (2016-06-17 10:04:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 11:30:11 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 11:31:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb73cd4e09dd03434c0d837aefa3dcf7ef2137e9
Cr-Commit-Position: refs/heads/master@{#400413}

Powered by Google App Engine
This is Rietveld 408576698