Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2074933005: [wasm] Handlify WasmDebugInfo where needed (Closed)

Created:
4 years, 6 months ago by Clemens Hammacher
Modified:
4 years, 6 months ago
Reviewers:
titzer, clemensh, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Handlify WasmDebugInfo where needed All function which potentially do heap allocations now take a Handle on a WasmDebugInfo. This unfortunately requires to make some function static, since otherwise the "this" pointer would not be handlified. R=ahaas@chromium.org, titzer@chromium.org BUG=chromium:613110 Committed: https://crrev.com/48a96d172010e5fc55a0a614ba53054a7ce544aa Cr-Commit-Position: refs/heads/master@{#37099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M src/wasm/wasm-debug.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/wasm/wasm-debug.cc View 7 chunks +16 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Clemens Hammacher
4 years, 6 months ago (2016-06-17 14:00:20 UTC) #2
ahaas
lgtm
4 years, 6 months ago (2016-06-20 09:08:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074933005/1
4 years, 6 months ago (2016-06-20 10:40:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 11:05:41 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 11:06:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48a96d172010e5fc55a0a614ba53054a7ce544aa
Cr-Commit-Position: refs/heads/master@{#37099}

Powered by Google App Engine
This is Rietveld 408576698