Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2074933004: Add support for showing latest dev/stable versions (Closed)

Created:
4 years, 6 months ago by kustermann
Modified:
4 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, asandholm
Base URL:
git@github.com:dart-lang/pub-dartlang-dart.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added escaping & addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -65 lines) Patch
M app/lib/handlers.dart View 1 4 chunks +77 lines, -32 lines 0 comments Download
M app/lib/package_memcache.dart View 1 4 chunks +16 lines, -9 lines 0 comments Download
M app/lib/templates.dart View 1 6 chunks +38 lines, -23 lines 0 comments Download
M app/views/pkg/show.mustache View 1 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
kustermann
4 years, 6 months ago (2016-06-16 21:58:28 UTC) #2
kustermann
See https://pub.dartlang.org/packages/polymer
4 years, 6 months ago (2016-06-16 21:58:47 UTC) #3
kustermann
The url encoding / escaping is still missing.
4 years, 6 months ago (2016-06-16 22:00:10 UTC) #4
Søren Gjesse
lgtm https://codereview.chromium.org/2074933004/diff/1/app/lib/handlers.dart File app/lib/handlers.dart (right): https://codereview.chromium.org/2074933004/diff/1/app/lib/handlers.dart#newcode287 app/lib/handlers.dart:287: packageVersionHandlerHtml(request, String packageName, String versionName) async { Long ...
4 years, 6 months ago (2016-06-17 07:03:37 UTC) #5
kustermann
Thanks. https://codereview.chromium.org/2074933004/diff/1/app/lib/handlers.dart File app/lib/handlers.dart (right): https://codereview.chromium.org/2074933004/diff/1/app/lib/handlers.dart#newcode287 app/lib/handlers.dart:287: packageVersionHandlerHtml(request, String packageName, String versionName) async { On ...
4 years, 5 months ago (2016-06-28 09:53:31 UTC) #6
kustermann
4 years, 5 months ago (2016-06-28 09:54:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2f42611ec0a0a73116dff570f36e5adc573234c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698