Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2074923002: Mojom C Generator: Small fixes to get generated C bindings to compile. (Closed)

Created:
4 years, 6 months ago by vardhan
Modified:
4 years, 6 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom C Generator: Small fixes to get generated C bindings to compile. The changes are: - Suffix int literals with "ul", "ull", etc. - Include MinVersion attribute in the type tables (the corresponding type table struct lives in mojo/public/c/bindings/, not yet committed) and reorder the fields for better packing. - Declare type tables before defining them (since definitions may have references to things that aren't defined yet.) R=azani@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/1b3ee424d5f1eee96009bc930d775ecb88cc8d9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -50 lines) Patch
M mojo/public/tools/bindings/mojom_tool/bin/linux64/generators/c.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/generators/c.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojom/generators/c/cgen/header.go View 1 chunk +2 lines, -2 lines 0 comments Download
M mojom/generators/c/cgen/type_table.go View 5 chunks +20 lines, -14 lines 0 comments Download
M mojom/generators/c/cgen/type_translation.go View 3 chunks +7 lines, -7 lines 0 comments Download
M mojom/generators/c/templates/header.tmpl.go View 1 chunk +7 lines, -6 lines 0 comments Download
M mojom/generators/c/templates/source.tmpl.go View 1 chunk +1 line, -6 lines 0 comments Download
M mojom/generators/c/templates/type_table.tmpl.go View 2 chunks +34 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vardhan
ptal
4 years, 6 months ago (2016-06-16 21:20:58 UTC) #3
azani
lgtm
4 years, 6 months ago (2016-06-16 21:30:42 UTC) #4
vardhan
4 years, 6 months ago (2016-06-16 21:43:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b3ee424d5f1eee96009bc930d775ecb88cc8d9e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698