Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2074903002: [turbofan] Numeric type feedback for mul, div and mod. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Numeric type feedback for mul, div and mod. This introduces handling number feedback for multiplication, division and modulus. At the moment, the only effect is using deoptimizing number conversion instead of ToNumber call. Committed: https://crrev.com/c500a3d318986aed0bdae87a39ff7bbb45e36126 Cr-Commit-Position: refs/heads/master@{#37081}

Patch Set 1 #

Patch Set 2 : Disable DCHECK to allow speculative typing. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -43 lines) Patch
M src/compiler/js-typed-lowering.cc View 3 chunks +17 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/operation-typer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/operation-typer.cc View 2 chunks +74 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 8 chunks +123 lines, -27 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 3 chunks +19 lines, -14 lines 0 comments Download
M src/compiler/typer.cc View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-06-19 15:06:26 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-19 18:15:51 UTC) #4
Benedikt Meurer
lgtm lgtm
4 years, 6 months ago (2016-06-19 18:15:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074903002/40001
4 years, 6 months ago (2016-06-19 18:16:00 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-19 18:46:09 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-19 18:46:51 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c500a3d318986aed0bdae87a39ff7bbb45e36126
Cr-Commit-Position: refs/heads/master@{#37081}

Powered by Google App Engine
This is Rietveld 408576698