Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.h

Issue 2074863002: [Reland] Worker: Protect a running debugger task from forcible worker termination (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pick up a part of code that this CL depends on from https://codereview.chromium.org/2053273002/ Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/workers/WorkerThread.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.h b/third_party/WebKit/Source/core/workers/WorkerThread.h
index 3a1de279867b357456c7c840563a261077303a49..d31ff1f496119513447d8750c5c3bf15404cf50d 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThread.h
+++ b/third_party/WebKit/Source/core/workers/WorkerThread.h
@@ -34,6 +34,7 @@
#include "core/workers/WorkerLoaderProxy.h"
#include "core/workers/WorkerThreadLifecycleObserver.h"
#include "platform/LifecycleNotifier.h"
+#include "platform/WaitableEvent.h"
#include "wtf/Forward.h"
#include "wtf/Functional.h"
#include "wtf/OwnPtr.h"
@@ -43,7 +44,6 @@
namespace blink {
class InspectorTaskRunner;
-class WaitableEvent;
class WorkerBackingThread;
class WorkerGlobalScope;
class WorkerInspectorController;
@@ -152,6 +152,8 @@ public:
ExitCode getExitCode();
+ void waitForShutdownForTesting() { m_shutdownEvent->wait(); }
+
protected:
WorkerThread(PassRefPtr<WorkerLoaderProxy>, WorkerReportingProxy&);
@@ -164,6 +166,7 @@ protected:
private:
friend class WorkerThreadTest;
+ FRIEND_TEST_ALL_PREFIXES(WorkerThreadTest, StartAndTerminateOnScriptLoaded_TerminateWhileDebuggerTaskIsRunning);
class ForceTerminationTask;
class WorkerMicrotaskRunner;
@@ -190,8 +193,6 @@ private:
void performDebuggerTaskOnWorkerThread(std::unique_ptr<CrossThreadClosure>);
void performDebuggerTaskDontWaitOnWorkerThread();
- void setForceTerminationDelayInMsForTesting(long long forceTerminationDelayInMs) { m_forceTerminationDelayInMs = forceTerminationDelayInMs; }
-
bool m_started = false;
bool m_terminated = false;
bool m_readyToShutdown = false;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698