presubmit_canned_checks.py - Issue 2074793002: Enforce GN formatting for *.typemap files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 2074793002: Enforce GN formatting for *.typemap files. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 7ec058b74baba1911b4cc6613e24be628ba5a2f3..15e24e29d86e338ec4e6ef25c7997b6342e6c3ed 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -1170,7 +1170,8 @@ def CheckGNFormatted(input_api, output_api):

affected_files = input_api.AffectedFiles(

include_deletes=False,

file_filter=lambda x: x.LocalPath().endswith('.gn') or

- x.LocalPath().endswith('.gni'))

+ x.LocalPath().endswith('.gni') or

+ x.LocalPath().endswith('.typemap'))

warnings = []

for f in affected_files:

cmd = ['gn', 'format', '--dry-run', f.AbsoluteLocalPath()]

« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »