Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2074793002: Enforce GN formatting for *.typemap files. (Closed)

Created:
4 years, 6 months ago by kylechar
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, sadrul, Ken Rockot(use gerrit already), yzshen1
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enforce GN formatting for *.typemap files. Ensure consistent formatting for Mojo typemap files that define the build rules to generate StructTraits. BUG=620799 TEST=Tested locally, both presubmit and git cl format work as expected. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/58edce2b909d295f97ccfbaf13705185541eca13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download
M presubmit_canned_checks.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074793002/1
4 years, 6 months ago (2016-06-16 17:59:21 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 6 months ago (2016-06-16 17:59:23 UTC) #5
kylechar
4 years, 6 months ago (2016-06-16 18:15:41 UTC) #8
tandrii(chromium)
I have no idea what typemap is, so leaving to Dirk to review. As for ...
4 years, 6 months ago (2016-06-16 18:21:38 UTC) #10
kylechar
On 2016/06/16 18:21:38, tandrii(chromium) wrote: > I have no idea what typemap is, so leaving ...
4 years, 6 months ago (2016-06-16 20:59:54 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074793002/1
4 years, 6 months ago (2016-06-16 21:00:05 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 21:03:14 UTC) #15
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-16 21:04:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074793002/1
4 years, 6 months ago (2016-06-17 13:04:37 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 13:07:54 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/58edce2b909d29...

Powered by Google App Engine
This is Rietveld 408576698