ios/web/web_state/web_state_delegate_bridge.mm - Issue 2074733002: Add public API for handling Javascript alerts and prompt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/web_state_delegate_bridge.mm

Issue 2074733002: Add public API for handling Javascript alerts and prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unittests. Address missed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/web/web_state/ui/crw_web_controller.mm ('K') | « ios/web/web_state/web_state_delegate.mm ('k') | ios/web/web_state/web_state_delegate_bridge_unittest.mm » ('j') | ios/web/web_state/web_state_impl_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/web_state/web_state_delegate_bridge.mm

diff --git a/ios/web/web_state/web_state_delegate_bridge.mm b/ios/web/web_state/web_state_delegate_bridge.mm

index 1e279aa9e41d9cd3d3d808b3f48af67c1fd2cc1a..23fc5fe8f07bd5d529b9d79952bf616487fba1c3 100644

--- a/ios/web/web_state/web_state_delegate_bridge.mm

+++ b/ios/web/web_state/web_state_delegate_bridge.mm

@@ -29,4 +29,14 @@ bool WebStateDelegateBridge::HandleContextMenu(

return NO;

}

+JavaScriptDialogPresenter* WebStateDelegateBridge::GetJavaScriptDialogPresenter(

+ WebState* source) {

+ if ([delegate_

+ respondsToSelector:@selector(

Eugene But (OOO till 7-30) 2016/06/28 18:14:48 Optional NIT: Could you please move SEL to a separ

michaeldo 2016/06/28 21:58:27 Done.

+ javaScriptDialogPresenterForWebState:)]) {

+ return [delegate_ javaScriptDialogPresenterForWebState:source];

+ }

+ return nullptr;

} // web