Add public API for handling Javascript alerts and prompt.

ios/web/web_state/web_state_impl_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/web/web_state/web_state_impl.h"
 
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/mac/bind_objc_block.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/ios/wait_util.h"
 #include "base/values.h"
 #include "ios/web/public/load_committed_details.h"
 #include "ios/web/public/test/test_browser_state.h"
 #include "ios/web/public/test/web_test.h"
+#include "ios/web/public/web_state/context_menu_params.h"
 #include "ios/web/public/web_state/global_web_state_observer.h"
 #include "ios/web/public/web_state/web_state_delegate.h"
 #include "ios/web/public/web_state/web_state_observer.h"
 #include "ios/web/public/web_state/web_state_policy_decider.h"
 #include "ios/web/web_state/global_web_state_event_tracker.h"
 #import "ios/web/web_state/ui/crw_web_controller.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 78 matching lines @@
   bool did_start_loading_called_;
   bool did_stop_loading_called_;
   bool page_loaded_called_with_success_;
   bool web_state_destroyed_called_;
 };
 
 // Test delegate to check that the WebStateDelegate methods are called as
 // expected.
 class TestWebStateDelegate : public WebStateDelegate {
  public:
-  TestWebStateDelegate() : load_progress_changed_called_(false) {}
+  TestWebStateDelegate()
+      : load_progress_changed_called_(false),
+        handle_context_menu_called_(false),
+        get_java_script_dialog_presenter_called_(false) {}
 
-  // Methods returning true if the corresponding WebStateObserver method has
-  // been called.
+  // True if the WebStateDelegate LoadProgressChanged method has been called.
   bool load_progress_changed_called() const {
     return load_progress_changed_called_;
   }
 
+  // True if the WebStateDelegate HandleContextMenu method has been called.
+  bool handle_context_menu_called() const {
+    return handle_context_menu_called_;
+  }
+
+  // True if the WebStateDelegate GetJavaScriptDialogPresenter method has been
+  // called.
+  bool get_java_script_dialog_presenter_called() const {
+    return get_java_script_dialog_presenter_called_;
+  }
+
  private:
-  // WebStateObserver implementation:
+  // WebStateDelegate implementation:
   void LoadProgressChanged(WebState* source, double progress) override {
     load_progress_changed_called_ = true;
   }
 
+  bool HandleContextMenu(WebState* source,
+                         const ContextMenuParams& params) override {
+    handle_context_menu_called_ = true;
+    return NO;
+  }
+
+  JavaScriptDialogPresenter* GetJavaScriptDialogPresenter(
+      WebState* source) override {
+    get_java_script_dialog_presenter_called_ = true;
+    return nullptr;

[Eugene But (OOO till 7-30), 2016/06/28 18:14:48]

How about adding SetJavaScriptDialogPresenter and making sure that
web_state_->RunJavaScriptDialog actually calls appropriate method on
JavaScriptDialogPresenter? We can do better than just verifying that delegate
method was called.

[michaeldo, 2016/06/28 21:58:27]

I like that idea. Done.

+  }
+
   bool load_progress_changed_called_;
+  bool handle_context_menu_called_;
+  bool get_java_script_dialog_presenter_called_;
 };
 
 // Test observer to check that the WebStateObserver methods are called as
 // expected.
 class TestWebStateObserver : public WebStateObserver {
  public:
   TestWebStateObserver(WebState* web_state)
       : WebStateObserver(web_state),
         provisional_navigation_started_called_(false),
         navigation_items_pruned_called_(false),
@@ skipping 264 matching lines @@
 
 // Tests that WebStateDelegate methods appropriately called.
 TEST_F(WebStateTest, DelegateTest) {
   TestWebStateDelegate delegate;
   web_state_->SetDelegate(&delegate);
 
   // Test that LoadProgressChanged() is called.
   EXPECT_FALSE(delegate.load_progress_changed_called());
   web_state_->SendChangeLoadProgress(0.0);
   EXPECT_TRUE(delegate.load_progress_changed_called());
+
+  // Test that HandleContextMenu() is called.
+  EXPECT_FALSE(delegate.handle_context_menu_called());
+  web::ContextMenuParams context_menu_params;
+  web_state_->HandleContextMenu(context_menu_params);
+  EXPECT_TRUE(delegate.handle_context_menu_called());
+
+  // Test that GetJavaScriptDialogPresenter() is called.
+  EXPECT_FALSE(delegate.get_java_script_dialog_presenter_called());
+  __block bool callback_called = false;
+  web_state_->RunJavaScriptDialog(GURL(), JAVASCRIPT_DIALOG_TYPE_ALERT, @"",
+                                  nil, base::BindBlock(^(BOOL, NSString*) {
+                                    callback_called = true;
+                                  }));
+  EXPECT_TRUE(delegate.get_java_script_dialog_presenter_called());
+  // Callback will be immediately run since we provide no presenter in
+  // our TestWebStateDelegate's |GetJavaScriptDialogPresenter| method.
+  EXPECT_TRUE(callback_called);
 }
 
 // Verifies that GlobalWebStateObservers are called when expected.
 TEST_F(WebStateTest, GlobalObserverTest) {
   std::unique_ptr<TestGlobalWebStateObserver> observer(
       new TestGlobalWebStateObserver());
 
   // Test that NavigationItemsPruned() is called.
   EXPECT_FALSE(observer->navigation_items_pruned_called());
   web_state_->OnNavigationItemsPruned(1);
@@ skipping 197 matching lines @@
       "</script>");
 
   base::test::ios::WaitUntilCondition(^{
     return message_received;
   });
   web_state_->RemoveScriptCommandCallback("test");
 }
 
 }  // namespace
 }  // namespace web