Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2074703002: [turbofan] Implicitly emit eager checkpoint at graph building. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-graph-builder-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implicitly emit eager checkpoint at graph building. This makes preparation of eager checkpoints within the graph builder implicit. Every sub-expression visitation is now guaranteed to emit valid checkpoints in AstContext. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/74e328efee7995aeee6d568f9d14f9bbc1087100 Cr-Commit-Position: refs/heads/master@{#37368}

Patch Set 1 #

Patch Set 2 : Drop explicit calls. #

Patch Set 3 : Trim frame states away. #

Patch Set 4 : Cleanup for-in bailout point. #

Patch Set 5 : Rebased. #

Patch Set 6 : Fix VisitInDuplicateContext (1). #

Patch Set 7 : Fix VisitInDuplicateContext (2). #

Patch Set 8 : Improved approach. #

Patch Set 9 : Fix tail call optimization. #

Patch Set 10 : Remove obsolete trimming again. #

Patch Set 11 : Add verification of bailout ids. #

Patch Set 12 : More fixes. #

Patch Set 13 : More fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -121 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 3 7 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 58 chunks +100 lines, -116 lines 0 comments Download
M src/compiler/checkpoint-elimination.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/checkpoint-elimination.cc View 1 2 3 4 5 6 7 8 1 chunk +27 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-16 14:14:01 UTC) #1
Michael Starzinger
PTAL. This should now be ready for prime time.
4 years, 5 months ago (2016-06-28 18:01:00 UTC) #3
Jarin
lgtm. I love it. Thanks for fixing the bugs!
4 years, 5 months ago (2016-06-28 21:21:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2074703002/260001
4 years, 5 months ago (2016-06-29 08:00:28 UTC) #6
commit-bot: I haz the power
Committed patchset #13 (id:260001)
4 years, 5 months ago (2016-06-29 08:42:23 UTC) #7
commit-bot: I haz the power
Patchset 13 (id:??) landed as https://crrev.com/74e328efee7995aeee6d568f9d14f9bbc1087100 Cr-Commit-Position: refs/heads/master@{#37368}
4 years, 5 months ago (2016-06-29 08:44:52 UTC) #9
Michael Starzinger
4 years, 5 months ago (2016-06-29 09:18:21 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #13 id:260001) has been created in
https://codereview.chromium.org/2104973004/ by mstarzinger@chromium.org.

The reason for reverting is: Causers flaky failures on the waterfall on Mac with
the following error in the builtin QuickSort method:

#
# Fatal error in Zone
# Allocation failed - process out of memory
#.

Powered by Google App Engine
This is Rietveld 408576698