Make a copy of PageClassification enum outside the metrics code

chrome/browser/metrics/metrics_log.cc

Index: chrome/browser/metrics/metrics_log.cc
diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc
index af2613f17215b1fac0c165226a14b67c0cbbfafa..d37a95cf93e585f68ac91d8f9935be13a78ea315 100644
--- a/chrome/browser/metrics/metrics_log.cc
+++ b/chrome/browser/metrics/metrics_log.cc
@@ -141,6 +141,30 @@ OmniboxEventProto::Suggestion::ResultType AsOmniboxEventResultType(
   }
 }
 
+OmniboxEventProto::PageClassification AsOmniboxEventPageClassification(
+    AutocompleteInput::PageClassification page_classification) {
+  switch (page_classification) {
+    case AutocompleteInput::INVALID_SPEC:
+      return OmniboxEventProto::INVALID_SPEC;
+    case AutocompleteInput::NEW_TAB_PAGE:
+      return OmniboxEventProto::NEW_TAB_PAGE;
+    case AutocompleteInput::BLANK:
+      return OmniboxEventProto::BLANK;
+    case AutocompleteInput::HOMEPAGE:
+      return OmniboxEventProto::HOMEPAGE;
+    case AutocompleteInput::OTHER:
+      return OmniboxEventProto::OTHER;
+    case AutocompleteInput::INSTANT_NEW_TAB_PAGE:
+      return OmniboxEventProto::INSTANT_NEW_TAB_PAGE;
+    case AutocompleteInput::SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT:
+      return OmniboxEventProto::
+          SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;
+    default:

[Ilya Sherman, 2013/07/26 21:40:56]

nit: Please remove the default case, so that it's a compile-time error to forget
to update this.  (You'll still need to have the return stmt, just outside the
switch stmt, to satisfy less wise compilers.)

[Mark P, 2013/07/26 21:55:27]

Done.

+      NOTREACHED();
+      return OmniboxEventProto::INVALID_SPEC;
+  }
+}
+
 ProfilerEventProto::TrackedObject::ProcessType AsProtobufProcessType(
     int process_type) {
   switch (process_type) {
@@ -829,7 +853,7 @@ void MetricsLog::RecordOmniboxOpenedURL(const OmniboxLog& log) {
   omnibox_event->set_duration_since_last_default_match_update_ms(
       log.elapsed_time_since_last_change_to_default_match.InMilliseconds());
   omnibox_event->set_current_page_classification(
-      log.current_page_classification);
+      AsOmniboxEventPageClassification(log.current_page_classification));
   omnibox_event->set_input_type(AsOmniboxEventInputType(log.input_type));
   for (AutocompleteResult::const_iterator i(log.result.begin());
        i != log.result.end(); ++i) {