Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2912)

Unified Diff: chrome/browser/autocomplete/autocomplete_input.h

Issue 20747002: Make a copy of PageClassification enum outside the metrics code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ilya's comment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_input.h
diff --git a/chrome/browser/autocomplete/autocomplete_input.h b/chrome/browser/autocomplete/autocomplete_input.h
index d70a3afa1e10c034a4811c0141b64652e25529df..9f9788464b5bda49278ca5a4fff4dedb87cf6c71 100644
--- a/chrome/browser/autocomplete/autocomplete_input.h
+++ b/chrome/browser/autocomplete/autocomplete_input.h
@@ -44,6 +44,27 @@ class AutocompleteInput {
ALL_MATCHES,
};
+ // The type of page currently displayed.
+ // Note: when adding an element to this enum, please add it at the end
+ // and update omnibox_event.proto::PageClassification and
+ // omnibox_edit_model.cc::ClassifyPage() too.
+ enum PageClassification {
+ INVALID_SPEC = 0, // invalid URI; shouldn't happen
+ NEW_TAB_PAGE = 1, // chrome://newtab/
+ // Note that chrome://newtab/ doesn't have to be the built-in
+ // version; it could be replaced by an extension.
+ BLANK = 2, // about:blank
+ HOMEPAGE = 3, // user switched settings to "open this page" mode.
+ // Note that if the homepage is set to the new tab page or about blank,
+ // then we'll classify the web page into those categories, not HOMEPAGE.
+ OTHER = 4, // everything not included somewhere else on this list
+ INSTANT_NEW_TAB_PAGE = 5, // new tab page rendered by Instant
+ // The user is on a search result page that's doing search term
+ // replacement, meaning the search terms should've appeared in the omnibox
+ // before the user started editing it, not the URL of the page.
+ SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6
+ };
+
AutocompleteInput();
// |text| and |cursor_position| represent the input query and location of
// the cursor with the query respectively. |cursor_position| may be set to
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698