Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3020)

Unified Diff: chrome/browser/omnibox/omnibox_log.h

Issue 20747002: Make a copy of PageClassification enum outside the metrics code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/omnibox/omnibox_log.h
diff --git a/chrome/browser/omnibox/omnibox_log.h b/chrome/browser/omnibox/omnibox_log.h
index a31c9c7cedb86482615ba37b41a25a93b010c6b1..2b3d5aa3abfdabd32bf805204c73645d98bd0101 100644
--- a/chrome/browser/omnibox/omnibox_log.h
+++ b/chrome/browser/omnibox/omnibox_log.h
@@ -12,7 +12,6 @@
#include "chrome/browser/autocomplete/autocomplete_input.h"
#include "chrome/browser/autocomplete/autocomplete_provider.h"
#include "chrome/browser/sessions/session_id.h"
-#include "chrome/common/metrics/proto/omnibox_event.pb.h"
class AutocompleteResult;
@@ -25,8 +24,7 @@ struct OmniboxLog {
AutocompleteInput::Type input_type,
size_t selected_index,
SessionID::id_type tab_id,
- metrics::OmniboxEventProto::PageClassification
- current_page_classification,
+ AutocompleteInput::PageClassification current_page_classification,
base::TimeDelta elapsed_time_since_user_first_modified_omnibox,
size_t completed_length,
base::TimeDelta elapsed_time_since_last_change_to_default_match,
@@ -52,7 +50,7 @@ struct OmniboxLog {
// The type of page (e.g., new tab page, regular web page) that the
// user was viewing before going somewhere with the omnibox.
- metrics::OmniboxEventProto::PageClassification current_page_classification;
+ AutocompleteInput::PageClassification current_page_classification;
// The amount of time since the user first began modifying the text
// in the omnibox. If at some point after modifying the text, the

Powered by Google App Engine
This is Rietveld 408576698