Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6703)

Unified Diff: chrome/browser/ui/views/accelerator_table.cc

Issue 2074643003: MacViews: Views accelerators table should match the Cocoa one. (Closed) Base URL: ssh://bitbucket.browser.yandex-team.ru/chromium/src.git@master
Patch Set: Fix compilation. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/accelerator_table.cc
diff --git a/chrome/browser/ui/views/accelerator_table.cc b/chrome/browser/ui/views/accelerator_table.cc
index 818f5a83336dd01bbcaaf521843d96d650771790..43a548941588862dd9a88f01ae18fa6f89fbbb5c 100644
--- a/chrome/browser/ui/views/accelerator_table.cc
+++ b/chrome/browser/ui/views/accelerator_table.cc
@@ -22,53 +22,36 @@ namespace {
// For many commands, the Mac equivalent uses Cmd instead of Ctrl. We only need
// to list the ones that do not have a key equivalent in the main menu, i.e.
// only the ones in global_keyboard_shortcuts_mac.mm.
-// TODO(jackhou): If-def out the accelerators that should not be on Mac.
#if defined(OS_MACOSX)
const ui::EventFlags kPlatformModifier = ui::EF_COMMAND_DOWN;
#else
const ui::EventFlags kPlatformModifier = ui::EF_CONTROL_DOWN;
#endif
-// NOTE: Keep this list in the same (mostly-alphabetical) order as
-// the Windows accelerators in ../../app/chrome_dll.rc.
+// NOTE: Between each ifdef block, keep the list in the same
+// (mostly-alphabetical) order as the Windows accelerators in
+// ../../app/chrome_dll.rc.
// Do not use Ctrl-Alt as a shortcut modifier, as it is used by i18n keyboards:
// http://blogs.msdn.com/b/oldnewthing/archive/2004/03/29/101121.aspx
const AcceleratorMapping kAcceleratorMap[] = {
- { ui::VKEY_LEFT, ui::EF_ALT_DOWN, IDC_BACK },
{ ui::VKEY_BACK, ui::EF_NONE, IDC_BACKSPACE_BACK },
- { ui::VKEY_D, ui::EF_CONTROL_DOWN, IDC_BOOKMARK_PAGE },
- { ui::VKEY_D, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+ { ui::VKEY_D, kPlatformModifier, IDC_BOOKMARK_PAGE },
+ { ui::VKEY_D, ui::EF_SHIFT_DOWN | kPlatformModifier,
IDC_BOOKMARK_ALL_TABS },
- { ui::VKEY_W, ui::EF_CONTROL_DOWN, IDC_CLOSE_TAB },
- { ui::VKEY_W, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_CLOSE_WINDOW },
- { ui::VKEY_F, ui::EF_CONTROL_DOWN, IDC_FIND },
- { ui::VKEY_G, ui::EF_CONTROL_DOWN, IDC_FIND_NEXT },
- { ui::VKEY_G, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_FIND_PREVIOUS },
- { ui::VKEY_D, ui::EF_ALT_DOWN, IDC_FOCUS_LOCATION },
- { ui::VKEY_L, ui::EF_CONTROL_DOWN, IDC_FOCUS_LOCATION },
- { ui::VKEY_K, ui::EF_CONTROL_DOWN, IDC_FOCUS_SEARCH },
- { ui::VKEY_E, ui::EF_CONTROL_DOWN, IDC_FOCUS_SEARCH },
- { ui::VKEY_T, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_TOOLBAR },
- { ui::VKEY_B, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_BOOKMARKS },
- { ui::VKEY_A, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_INFOBARS },
- { ui::VKEY_RIGHT, ui::EF_ALT_DOWN, IDC_FORWARD },
+ { ui::VKEY_W, kPlatformModifier, IDC_CLOSE_TAB },
+ { ui::VKEY_W, ui::EF_SHIFT_DOWN | kPlatformModifier, IDC_CLOSE_WINDOW },
+ { ui::VKEY_F, kPlatformModifier, IDC_FIND },
+ { ui::VKEY_G, kPlatformModifier, IDC_FIND_NEXT },
+ { ui::VKEY_G, ui::EF_SHIFT_DOWN | kPlatformModifier, IDC_FIND_PREVIOUS },
+ { ui::VKEY_L, kPlatformModifier, IDC_FOCUS_LOCATION },
{ ui::VKEY_BACK, ui::EF_SHIFT_DOWN, IDC_BACKSPACE_FORWARD },
- { ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_DEV_TOOLS },
{ ui::VKEY_F12, ui::EF_NONE, IDC_DEV_TOOLS_TOGGLE },
- { ui::VKEY_J, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
- IDC_DEV_TOOLS_CONSOLE },
- { ui::VKEY_C, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
- IDC_DEV_TOOLS_INSPECT },
- { ui::VKEY_O, ui::EF_CONTROL_DOWN, IDC_OPEN_FILE },
- { ui::VKEY_P, ui::EF_CONTROL_DOWN, IDC_PRINT},
-#if BUILDFLAG(ENABLE_BASIC_PRINTING)
- { ui::VKEY_P, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_BASIC_PRINT},
-#endif // ENABLE_BASIC_PRINTING
- { ui::VKEY_R, ui::EF_CONTROL_DOWN, IDC_RELOAD },
- { ui::VKEY_R, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+ { ui::VKEY_O, kPlatformModifier, IDC_OPEN_FILE },
+ { ui::VKEY_P, kPlatformModifier, IDC_PRINT },
+ { ui::VKEY_R, kPlatformModifier, IDC_RELOAD },
+ { ui::VKEY_R, ui::EF_SHIFT_DOWN | kPlatformModifier,
IDC_RELOAD_BYPASSING_CACHE },
- { ui::VKEY_HOME, ui::EF_ALT_DOWN, IDC_HOME },
- { ui::VKEY_S, ui::EF_CONTROL_DOWN, IDC_SAVE_PAGE },
+ { ui::VKEY_S, kPlatformModifier, IDC_SAVE_PAGE },
{ ui::VKEY_9, kPlatformModifier, IDC_SELECT_LAST_TAB },
{ ui::VKEY_NUMPAD9, kPlatformModifier, IDC_SELECT_LAST_TAB },
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
@@ -78,6 +61,8 @@ const AcceleratorMapping kAcceleratorMap[] = {
{ ui::VKEY_PRIOR, ui::EF_CONTROL_DOWN | ui::EF_SHIFT_DOWN,
IDC_MOVE_TAB_PREVIOUS },
#endif
+ // Control modifier is rarely used on Mac, so we allow it only in several
+ // specific cases.
{ ui::VKEY_TAB, ui::EF_CONTROL_DOWN, IDC_SELECT_NEXT_TAB },
{ ui::VKEY_NEXT, ui::EF_CONTROL_DOWN, IDC_SELECT_NEXT_TAB },
{ ui::VKEY_TAB, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
@@ -117,23 +102,18 @@ const AcceleratorMapping kAcceleratorMap[] = {
{ ui::VKEY_8, ui::EF_ALT_DOWN, IDC_SELECT_TAB_7 },
{ ui::VKEY_NUMPAD8, ui::EF_ALT_DOWN, IDC_SELECT_TAB_7 },
{ ui::VKEY_BROWSER_FAVORITES, ui::EF_NONE, IDC_SHOW_BOOKMARK_BAR },
-#endif
- { ui::VKEY_B, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+#endif // OS_LINUX && !OS_CHROMEOS
+ { ui::VKEY_B, ui::EF_SHIFT_DOWN | kPlatformModifier,
IDC_SHOW_BOOKMARK_BAR },
- { ui::VKEY_O, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
- IDC_SHOW_BOOKMARK_MANAGER },
- { ui::VKEY_J, ui::EF_CONTROL_DOWN, IDC_SHOW_DOWNLOADS },
- { ui::VKEY_H, ui::EF_CONTROL_DOWN, IDC_SHOW_HISTORY },
- { ui::VKEY_F, ui::EF_ALT_DOWN, IDC_SHOW_APP_MENU},
- { ui::VKEY_E, ui::EF_ALT_DOWN, IDC_SHOW_APP_MENU},
{ ui::VKEY_ESCAPE, ui::EF_NONE, IDC_STOP },
- { ui::VKEY_U, ui::EF_CONTROL_DOWN, IDC_VIEW_SOURCE },
- { ui::VKEY_OEM_MINUS, ui::EF_CONTROL_DOWN, IDC_ZOOM_MINUS },
- { ui::VKEY_SUBTRACT, ui::EF_CONTROL_DOWN, IDC_ZOOM_MINUS },
- { ui::VKEY_0, ui::EF_CONTROL_DOWN, IDC_ZOOM_NORMAL },
- { ui::VKEY_NUMPAD0, ui::EF_CONTROL_DOWN, IDC_ZOOM_NORMAL },
- { ui::VKEY_OEM_PLUS, ui::EF_CONTROL_DOWN, IDC_ZOOM_PLUS },
- { ui::VKEY_ADD, ui::EF_CONTROL_DOWN, IDC_ZOOM_PLUS },
+ { ui::VKEY_OEM_MINUS, kPlatformModifier, IDC_ZOOM_MINUS },
+ { ui::VKEY_SUBTRACT, kPlatformModifier, IDC_ZOOM_MINUS },
+ { ui::VKEY_0, kPlatformModifier, IDC_ZOOM_NORMAL },
+ { ui::VKEY_NUMPAD0, kPlatformModifier, IDC_ZOOM_NORMAL },
+ { ui::VKEY_OEM_PLUS, kPlatformModifier, IDC_ZOOM_PLUS },
+ { ui::VKEY_ADD, kPlatformModifier, IDC_ZOOM_PLUS },
+
+#if !defined(OS_MACOSX) // Function keys aren't mapped on Mac.
{ ui::VKEY_F1, ui::EF_NONE, IDC_HELP_PAGE_VIA_KEYBOARD },
{ ui::VKEY_F3, ui::EF_NONE, IDC_FIND_NEXT },
{ ui::VKEY_F3, ui::EF_SHIFT_DOWN, IDC_FIND_PREVIOUS },
@@ -146,6 +126,7 @@ const AcceleratorMapping kAcceleratorMap[] = {
{ ui::VKEY_F6, ui::EF_SHIFT_DOWN, IDC_FOCUS_PREVIOUS_PANE },
{ ui::VKEY_F10, ui::EF_NONE, IDC_FOCUS_MENU_BAR },
{ ui::VKEY_F11, ui::EF_NONE, IDC_FULLSCREEN },
+#endif // !OS_MACOSX
// Platform-specific key maps.
#if defined(OS_LINUX)
@@ -168,35 +149,115 @@ const AcceleratorMapping kAcceleratorMap[] = {
{ ui::VKEY_BROWSER_STOP, ui::EF_NONE, IDC_STOP },
{ ui::VKEY_P, ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN,
IDC_TOUCH_HUD_PROJECTION_TOGGLE },
-#else // OS_CHROMEOS
+#else // !OS_CHROMEOS
{ ui::VKEY_ESCAPE, ui::EF_SHIFT_DOWN, IDC_TASK_MANAGER },
- { ui::VKEY_DELETE, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
- IDC_CLEAR_BROWSING_DATA },
{ ui::VKEY_LMENU, ui::EF_NONE, IDC_FOCUS_MENU_BAR },
{ ui::VKEY_MENU, ui::EF_NONE, IDC_FOCUS_MENU_BAR },
{ ui::VKEY_RMENU, ui::EF_NONE, IDC_FOCUS_MENU_BAR },
// On Windows, all VKEY_BROWSER_* keys except VKEY_BROWSER_SEARCH are handled
// via WM_APPCOMMAND.
{ ui::VKEY_BROWSER_SEARCH, ui::EF_NONE, IDC_FOCUS_SEARCH },
- { ui::VKEY_M, ui::EF_SHIFT_DOWN | kPlatformModifier, IDC_SHOW_AVATAR_MENU},
- // On Chrome OS, these keys are assigned to change UI scale.
- { ui::VKEY_OEM_PLUS, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_ZOOM_PLUS },
- { ui::VKEY_OEM_MINUS, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
- IDC_ZOOM_MINUS },
- // For each entry here add an entry into kChromeCmdId2AshActionId below
- // if Ash has a corresponding accelerator.
-#if defined(GOOGLE_CHROME_BUILD)
+ { ui::VKEY_M, ui::EF_SHIFT_DOWN | kPlatformModifier, IDC_SHOW_AVATAR_MENU },
+ // For each entry until the end of the !OS_CHROMEOS block, and an entry into
+ // kChromeCmdId2AshActionId below if Ash has a corresponding accelerator.
+#if defined(GOOGLE_CHROME_BUILD) && !defined(OS_MACOSX)
{ ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FEEDBACK },
-#endif
+#endif // GOOGLE_CHROME_BUILD && !OS_MACOSX
+#if !defined(OS_MACOSX)
{ ui::VKEY_Q, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_EXIT },
- { ui::VKEY_N, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+#endif // !OS_MACOSX
+ { ui::VKEY_N, ui::EF_SHIFT_DOWN | kPlatformModifier,
IDC_NEW_INCOGNITO_WINDOW },
- { ui::VKEY_T, ui::EF_CONTROL_DOWN, IDC_NEW_TAB },
- { ui::VKEY_N, ui::EF_CONTROL_DOWN, IDC_NEW_WINDOW },
- { ui::VKEY_T, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_RESTORE_TAB },
-#endif
+ { ui::VKEY_T, kPlatformModifier, IDC_NEW_TAB },
+ { ui::VKEY_N, kPlatformModifier, IDC_NEW_WINDOW },
+ { ui::VKEY_T, ui::EF_SHIFT_DOWN | kPlatformModifier, IDC_RESTORE_TAB },
+#endif // !OS_CHROMEOS
+
+#if defined(OS_MACOSX)
+ // VKEY_OEM_4 is Left Brace '[{' key.
+ { ui::VKEY_OEM_4, ui::EF_COMMAND_DOWN, IDC_BACK },
+ { ui::VKEY_LEFT, ui::EF_COMMAND_DOWN, IDC_BACK },
+#if BUILDFLAG(ENABLE_BASIC_PRINTING)
+ { ui::VKEY_P, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN, IDC_BASIC_PRINT },
+#endif // ENABLE_BASIC_PRINTING
+ { ui::VKEY_BACK, ui::EF_COMMAND_DOWN | ui::EF_SHIFT_DOWN,
+ IDC_CLEAR_BROWSING_DATA },
+ { ui::VKEY_V, ui::EF_COMMAND_DOWN | ui::EF_SHIFT_DOWN,
+ IDC_CONTENT_CONTEXT_PASTE_AND_MATCH_STYLE },
+ { ui::VKEY_Z, ui::EF_COMMAND_DOWN | ui::EF_SHIFT_DOWN,
+ IDC_CONTENT_CONTEXT_REDO },
+ { ui::VKEY_A, ui::EF_COMMAND_DOWN, IDC_CONTENT_CONTEXT_SELECTALL },
+ { ui::VKEY_Z, ui::EF_COMMAND_DOWN, IDC_CONTENT_CONTEXT_UNDO },
+ { ui::VKEY_I, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN, IDC_DEV_TOOLS },
+ { ui::VKEY_J, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN, IDC_DEV_TOOLS_CONSOLE },
+ { ui::VKEY_C, ui::EF_COMMAND_DOWN | ui::EF_SHIFT_DOWN, IDC_DEV_TOOLS_INSPECT},
+ { ui::VKEY_I, ui::EF_COMMAND_DOWN | ui::EF_SHIFT_DOWN,
+ IDC_EMAIL_PAGE_LOCATION },
+ { ui::VKEY_Q, ui::EF_COMMAND_DOWN, IDC_EXIT },
+ { ui::VKEY_F, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_SEARCH },
+ // VKEY_OEM_6 is Right Brace ']}' key.
+ { ui::VKEY_OEM_6, ui::EF_COMMAND_DOWN, IDC_FORWARD },
+ { ui::VKEY_RIGHT, ui::EF_COMMAND_DOWN, IDC_FORWARD },
+ { ui::VKEY_F, ui::EF_COMMAND_DOWN | ui::EF_CONTROL_DOWN, IDC_FULLSCREEN },
+ // VKEY_OEM_2 is Slash '/?' key.
+ { ui::VKEY_OEM_2, ui::EF_COMMAND_DOWN | ui::EF_SHIFT_DOWN,
+ IDC_HELP_PAGE_VIA_MENU },
+ { ui::VKEY_H, ui::EF_COMMAND_DOWN, IDC_HIDE_APP },
+ { ui::VKEY_H, ui::EF_COMMAND_DOWN | ui::EF_SHIFT_DOWN, IDC_HOME },
+ { ui::VKEY_M, ui::EF_COMMAND_DOWN, IDC_MINIMIZE_WINDOW },
+ { ui::VKEY_RIGHT, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN,
+ IDC_SELECT_NEXT_TAB },
+ { ui::VKEY_LEFT, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN,
+ IDC_SELECT_PREVIOUS_TAB },
+ { ui::VKEY_B, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN,
+ IDC_SHOW_BOOKMARK_MANAGER },
+ { ui::VKEY_J, ui::EF_COMMAND_DOWN | ui::EF_SHIFT_DOWN, IDC_SHOW_DOWNLOADS },
+ { ui::VKEY_L, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN, IDC_SHOW_DOWNLOADS },
+ { ui::VKEY_Y, ui::EF_COMMAND_DOWN, IDC_SHOW_HISTORY },
+ { ui::VKEY_OEM_PERIOD, ui::EF_COMMAND_DOWN, IDC_STOP },
+ { ui::VKEY_U, ui::EF_COMMAND_DOWN | ui::EF_ALT_DOWN, IDC_VIEW_SOURCE },
+#else // !OS_MACOSX
+ // Alt by itself (or with just shift) is never used on Mac since it's used
+ // to generate non-ASCII characters. Such commands are given Mac-specific
+ // bindings as well. Mapping with just Alt appear here, and should have an
+ // alternative mapping in the block above.
+ { ui::VKEY_LEFT, ui::EF_ALT_DOWN, IDC_BACK },
+#if BUILDFLAG(ENABLE_BASIC_PRINTING)
+ { ui::VKEY_P, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_BASIC_PRINT},
+#endif // ENABLE_BASIC_PRINTING
+#if !defined(OS_CHROMEOS)
+ { ui::VKEY_DELETE, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+ IDC_CLEAR_BROWSING_DATA },
+#endif // !OS_CHROMEOS
+ { ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_DEV_TOOLS },
+ { ui::VKEY_J, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+ IDC_DEV_TOOLS_CONSOLE },
+ { ui::VKEY_C, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+ IDC_DEV_TOOLS_INSPECT },
+ { ui::VKEY_B, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_BOOKMARKS },
+ { ui::VKEY_A, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_INFOBARS },
+ { ui::VKEY_D, ui::EF_ALT_DOWN, IDC_FOCUS_LOCATION },
+ { ui::VKEY_E, ui::EF_CONTROL_DOWN, IDC_FOCUS_SEARCH },
+ { ui::VKEY_K, ui::EF_CONTROL_DOWN, IDC_FOCUS_SEARCH },
+ { ui::VKEY_T, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_TOOLBAR },
+ { ui::VKEY_RIGHT, ui::EF_ALT_DOWN, IDC_FORWARD },
+ { ui::VKEY_HOME, ui::EF_ALT_DOWN, IDC_HOME },
+ { ui::VKEY_E, ui::EF_ALT_DOWN, IDC_SHOW_APP_MENU},
+ { ui::VKEY_F, ui::EF_ALT_DOWN, IDC_SHOW_APP_MENU},
+ { ui::VKEY_O, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+ IDC_SHOW_BOOKMARK_MANAGER },
+ { ui::VKEY_J, ui::EF_CONTROL_DOWN, IDC_SHOW_DOWNLOADS },
+ { ui::VKEY_H, ui::EF_CONTROL_DOWN, IDC_SHOW_HISTORY },
+ { ui::VKEY_U, ui::EF_CONTROL_DOWN, IDC_VIEW_SOURCE },
+#if !defined(OS_CHROMEOS)
+ // On Chrome OS, these keys are assigned to change UI scale.
+ { ui::VKEY_OEM_MINUS, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+ IDC_ZOOM_MINUS },
+ { ui::VKEY_OEM_PLUS, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
+ IDC_ZOOM_PLUS },
+#endif // !OS_CHROMEOS
+#endif // OS_MACOSX
};
-const size_t kAcceleratorMapLength = arraysize(kAcceleratorMap);
const int kRepeatableCommandIds[] = {
IDC_FIND_NEXT,
@@ -239,8 +300,10 @@ const size_t kChromeCmdId2AshActionIdLength =
} // namespace
std::vector<AcceleratorMapping> GetAcceleratorList() {
- return std::vector<AcceleratorMapping>(
- kAcceleratorMap, kAcceleratorMap + kAcceleratorMapLength);
+ CR_DEFINE_STATIC_LOCAL(
+ std::vector<AcceleratorMapping>, accelerators,
+ (std::begin(kAcceleratorMap), std::end(kAcceleratorMap)));
+ return accelerators;
}
bool GetAshAcceleratorForCommandId(int command_id,
@@ -268,13 +331,13 @@ bool GetStandardAcceleratorForCommandId(int command_id,
// anywhere else.
switch (command_id) {
case IDC_CUT:
- *accelerator = ui::Accelerator(ui::VKEY_X, ui::EF_CONTROL_DOWN);
+ *accelerator = ui::Accelerator(ui::VKEY_X, kPlatformModifier);
return true;
case IDC_COPY:
- *accelerator = ui::Accelerator(ui::VKEY_C, ui::EF_CONTROL_DOWN);
+ *accelerator = ui::Accelerator(ui::VKEY_C, kPlatformModifier);
return true;
case IDC_PASTE:
- *accelerator = ui::Accelerator(ui::VKEY_V, ui::EF_CONTROL_DOWN);
+ *accelerator = ui::Accelerator(ui::VKEY_V, kPlatformModifier);
return true;
}
return false;
« no previous file with comments | « chrome/browser/global_keyboard_shortcuts_views_mac.mm ('k') | chrome/browser/ui/views/accelerator_table_unittest_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698