chrome/browser/BUILD.gn - Issue 2074643003: MacViews: Views accelerators table should match the Cocoa one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 2074643003: MacViews: Views accelerators table should match the Cocoa one. (Closed) Base URL: ssh://bitbucket.browser.yandex-team.ru/chromium/src.git@master

Patch Set: Split global_keyboard_shortcuts_mac.mm into two platform-specific ones, simplified code. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index d9e0de941c90f540b672d67de9322d0689ab4bbc..7a3f5cd7dcc8a6852fa813e1cbcac8e5f2e77c90 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -3767,6 +3767,14 @@ split_static_library("browser") {

"chrome_browser_main_extra_parts_exo.h",

]

}

+ if (is_mac) {

tapted 2016/10/31 10:16:57 this should be merged with the if (is_mac) on line

themblsha 2016/10/31 16:56:29 Thanks. I'm getting lost in these huge GN files.

+ if (mac_views_browser) {

+ sources += [ "global_keyboard_shortcuts_views_mac.mm" ]

+ } else {

+ sources += [ "global_keyboard_shortcuts_cocoa_mac.mm" ]

+ }

}

if (android_java_ui) {

« no previous file with comments | « no previous file | chrome/browser/global_keyboard_shortcuts_cocoa_mac.mm » ('j') | chrome/browser/global_keyboard_shortcuts_cocoa_mac.mm » ('J')