Chromium Code Reviews Chromium Code Reviews
Issue 2074583003:
SkPDF: allow overriding Producer metadata (Closed)
Base URL: https://skia.googlesource.com/skia.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright 2013 Google Inc. | 2 * Copyright 2013 Google Inc. |
| 3 * | 3 * |
| 4 * Use of this source code is governed by a BSD-style license that can be | 4 * Use of this source code is governed by a BSD-style license that can be |
| 5 * found in the LICENSE file. | 5 * found in the LICENSE file. |
| 6 */ | 6 */ |
| 7 | 7 |
| 8 #ifndef SkDocument_DEFINED | 8 #ifndef SkDocument_DEFINED |
| 9 #define SkDocument_DEFINED | 9 #define SkDocument_DEFINED |
| 10 | 10 |
| (...skipping 29 matching lines...) Expand all Loading... | |
| 40 struct OptionalTimestamp { | 40 struct OptionalTimestamp { |
| 41 SkTime::DateTime fDateTime; | 41 SkTime::DateTime fDateTime; |
| 42 bool fEnabled; | 42 bool fEnabled; |
| 43 OptionalTimestamp() : fEnabled(false) {} | 43 OptionalTimestamp() : fEnabled(false) {} |
| 44 }; | 44 }; |
| 45 | 45 |
| 46 /** | 46 /** |
| 47 * Optional metadata to be passed into the PDF factory function. | 47 * Optional metadata to be passed into the PDF factory function. |
| 48 */ | 48 */ |
| 49 struct PDFMetadata { | 49 struct PDFMetadata { |
| 50 /** The document’s title. */ | |
| 50 SkString fTitle; | 51 SkString fTitle; |
| 52 /** The name of the person who created the document. */ | |
| 51 SkString fAuthor; | 53 SkString fAuthor; |
| 54 /** The subject of the document. */ | |
| 52 SkString fSubject; | 55 SkString fSubject; |
| 56 /** Keywords associated with the document. */ | |
|
reed1
2016/06/16 18:43:49
How are the words delineated?
hal.canary
2016/06/30 14:13:03
This is unspecified by the standard.
hal.canary
2016/06/30 14:44:20
New verbage:
/*
* Keywords associated with the d
| |
| 53 SkString fKeywords; | 57 SkString fKeywords; |
| 58 /** If the document was converted to PDF from another format, | |
|
reed1
2016/06/16 18:43:49
nit:
1. our comments have the closing */ on its o
hal.canary
2016/06/30 14:13:03
Done.
| |
| 59 the name of the conforming product that created the | |
| 60 original document from which it was converted. */ | |
|
reed1
2016/06/16 18:43:49
If Creator means a tool/product, should we conside
hal.canary
2016/06/30 14:13:03
I would rather match what the standard says.
| |
| 54 SkString fCreator; | 61 SkString fCreator; |
| 62 /** Leave fProducer empty to get the default, correct value. */ | |
|
reed1
2016/06/16 18:43:49
Lets first document what fProduce means, and then
hal.canary
2016/06/30 14:13:03
Done.
| |
| 63 SkString fProducer; | |
| 64 /** The date and time the document was created. */ | |
| 55 OptionalTimestamp fCreation; | 65 OptionalTimestamp fCreation; |
| 66 /** The date and time the document was most recently modified. */ | |
| 56 OptionalTimestamp fModified; | 67 OptionalTimestamp fModified; |
| 57 }; | 68 }; |
| 58 | 69 |
| 59 /** | 70 /** |
| 60 * Create a PDF-backed document, writing the results into a | 71 * Create a PDF-backed document, writing the results into a |
| 61 * SkWStream. | 72 * SkWStream. |
| 62 * | 73 * |
| 63 * PDF pages are sized in point units. 1 pt == 1/72 inch == | 74 * PDF pages are sized in point units. 1 pt == 1/72 inch == |
| 64 * 127/360 mm. | 75 * 127/360 mm. |
| 65 * | 76 * |
| (...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 271 | 282 |
| 272 private: | 283 private: |
| 273 SkWStream* fStream; | 284 SkWStream* fStream; |
| 274 void (*fDoneProc)(SkWStream*, bool aborted); | 285 void (*fDoneProc)(SkWStream*, bool aborted); |
| 275 State fState; | 286 State fState; |
| 276 | 287 |
| 277 typedef SkRefCnt INHERITED; | 288 typedef SkRefCnt INHERITED; |
| 278 }; | 289 }; |
| 279 | 290 |
| 280 #endif | 291 #endif |
| OLD | NEW |
