 Chromium Code Reviews
 Chromium Code Reviews Issue 2074563002:
  bluetooth: mac: write characteristic implementation  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@read_characteristicscan_servicescan_cleanup
    
  
    Issue 2074563002:
  bluetooth: mac: write characteristic implementation  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@read_characteristicscan_servicescan_cleanup| Index: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h | 
| diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h | 
| index d591f174aa4b6b10477995e66a71020a6283bd92..3a5334421bf999a075a907a50e05da42b50b7977 100644 | 
| --- a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h | 
| +++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h | 
| @@ -10,6 +10,7 @@ | 
| #include "base/mac/scoped_nsobject.h" | 
| @class CBCharacteristic; | 
| +typedef NS_ENUM(NSInteger, CBCharacteristicWriteType); | 
| 
msarda
2016/06/27 11:41:36
Why is this typedef needed? Could CoreBluetooth he
 
jlebel
2016/06/27 12:20:36
Done.
 | 
| namespace device { | 
| @@ -55,8 +56,15 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicMac | 
| // Called by the BluetoothRemoteGattServiceMac instance when the | 
| // characteristics value has been read. | 
| void DidUpdateValue(NSError* error); | 
| + // Called by the BluetoothRemoteGattServiceMac instance when the | 
| + // characteristics value has been written. | 
| + void DidWriteValue(NSError* error); | 
| // Returns true if the characteristic is readable. | 
| bool IsReadable() const; | 
| + // Returns true if the characteristic is writable. | 
| + bool IsWritable() const; | 
| + // Returns the write type (with or without responses). | 
| + CBCharacteristicWriteType GetCBWriteType() const; | 
| // Returns CoreBluetooth characteristic. | 
| CBCharacteristic* GetCBCharacteristic() const; | 
| @@ -74,6 +82,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicMac | 
| bool characteristic_value_read_or_write_in_progress_; | 
| // ReadRemoteCharacteristic request callbacks. | 
| std::pair<ValueCallback, ErrorCallback> read_characteristic_value_callbacks_; | 
| + // WriteRemoteCharacteristic request callbacks. | 
| + std::pair<base::Closure, ErrorCallback> write_characteristic_value_callbacks_; | 
| }; | 
| } // namespace device |