Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: components/arc/common/app.mojom

Issue 2074543003: ARC: Add a link to "Manage supported links" in the Chrome app info dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: I had a tough morning. Now fixed builds. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/common/app.mojom
diff --git a/components/arc/common/app.mojom b/components/arc/common/app.mojom
index 5bd5add137376fdd175d071d122c26a103bc1cfd..1d235140041e65debd92f3c912d3a4146979ea00 100644
--- a/components/arc/common/app.mojom
+++ b/components/arc/common/app.mojom
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
-// Next MinVersion: 8
+// Next MinVersion: 9
module arc.mojom;
@@ -18,6 +18,12 @@ struct AppInfo {
[MinVersion=7] bool notifications_enabled;
};
+// Page for ShowPackageInfoOnPage.
+enum ShowPackageInfoPage {
Yusuke Sato 2016/06/20 05:00:26 You probably want to add [Extensible] here so you
mtomasz 2016/06/20 05:14:58 Done.
+ MAIN = 0,
+ MANAGE_LINKS = 1,
+};
+
// Next method ID: 8
interface AppHost {
// Sends newly added ARC app to Chrome. This message is sent when ARC receives
@@ -58,7 +64,8 @@ interface AppHost {
};
// TODO(lhchavez): Migrate all request/response messages to Mojo.
-// Next method ID: 11
+// Next method ID: 12
+// Deprecated method ID: 9
interface AppInstance {
Init@0(AppHost host_ptr);
@@ -97,9 +104,16 @@ interface AppInstance {
[MinVersion=4] SetTaskActive@7(int32 task_id);
// Send a request to ARC to show package info for given package.
+ // Deprecated.
[MinVersion=5] ShowPackageInfo@9(string package_name,
Yusuke Sato 2016/06/20 05:00:26 Can you rename this to ShowPackageInfoDeprecated@9
mtomasz 2016/06/20 05:14:58 Done.
ScreenRect dimension_on_screen);
+ // Send a request to ARC to show package info for given package on the
+ // specified page.
+ [MinVersion=8] ShowPackageInfoOnPage@11(string package_name,
+ ShowPackageInfoPage page,
+ ScreenRect dimension_on_screen);
+
// Sets notification setting for the package.
[MinVersion=6] SetNotificationsEnabled@10(string package_name, bool enabled);

Powered by Google App Engine
This is Rietveld 408576698