ARC: Add a link to "Manage supported links" in the Chrome app info dialog.

ARC: Add a link to "Manage supported links" in the Chrome app info dialog.

It should only show up when ARC is enabled. b/29245776

TEST=Tested manually on Samus with ARC enabled and disabled.
BUG=621399
Committed: https://crrev.com/7cfdb68e2ca91ce3d073d4bf15bbaa5004bf120e
Cr-Commit-Position: refs/heads/master@{#401597}

[mtomasz, 2016-06-17 08:03:23]

mtomasz@chromium.org changed reviewers:
+ benwells@chromium.org, dcheng@chromium.org

[mtomasz, 2016-06-17 08:03:23]

@benwells: PTAL at chrome/browser/ui/*
@thakis: PTAL at components/arc/common/app.mojom

+cc @yusukes

[Yusuke Sato, 2016-06-20 05:00:25]

yusukes@chromium.org changed reviewers:
+ yusukes@chromium.org

[Yusuke Sato, 2016-06-20 05:00:26]

drive-by:

(and thanks a lot for working on the feature!)

https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
File components/arc/common/app.mojom (right):

https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
components/arc/common/app.mojom:22: enum ShowPackageInfoPage {
You probably want to add [Extensible] here so you can add more enum values
later.

 [Extensible]
 struct ShowPackageInfoPage {
   ...

https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
components/arc/common/app.mojom:108: [MinVersion=5] ShowPackageInfo@9(string
package_name,
Can you rename this to ShowPackageInfoDeprecated@9 just like auth.mojom and
intent_helper.mojom do?

https://codereview.chromium.org/2074543003/diff/140001/components/arc/test/fa...
File components/arc/test/fake_app_instance.h (right):

https://codereview.chromium.org/2074543003/diff/140001/components/arc/test/fa...
components/arc/test/fake_app_instance.h:90: mojom::ShowPackageInfoPage page,
wrong indent?

[Yusuke Sato, 2016-06-20 05:02:20]

On 2016/06/20 05:00:26, Yusuke Sato wrote:
> drive-by:
> 
> (and thanks a lot for working on the feature!)
> 
>
https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
> File components/arc/common/app.mojom (right):
> 
>
https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
> components/arc/common/app.mojom:22: enum ShowPackageInfoPage {
> You probably want to add [Extensible] here so you can add more enum values
> later.
> 
>  [Extensible]
>  struct ShowPackageInfoPage {
>    ...
> 
>
https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
> components/arc/common/app.mojom:108: [MinVersion=5] ShowPackageInfo@9(string
> package_name,
> Can you rename this to ShowPackageInfoDeprecated@9 just like auth.mojom and
> intent_helper.mojom do?
> 
>
https://codereview.chromium.org/2074543003/diff/140001/components/arc/test/fa...
> File components/arc/test/fake_app_instance.h (right):
> 
>
https://codereview.chromium.org/2074543003/diff/140001/components/arc/test/fa...
> components/arc/test/fake_app_instance.h:90: mojom::ShowPackageInfoPage page,
> wrong indent?

Please also file a placeholder bug on crbug.com (with just "for b/29245776" or
something) and use the crbug.com bug for your BUG= line. Rietveld cannot update
b/ atm.

[mtomasz, 2016-06-20 05:14:58]

Dones. Fixing tests now.

https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
File components/arc/common/app.mojom (right):

https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
components/arc/common/app.mojom:22: enum ShowPackageInfoPage {
On 2016/06/20 05:00:26, Yusuke Sato wrote:
> You probably want to add [Extensible] here so you can add more enum values
> later.
> 
>  [Extensible]
>  struct ShowPackageInfoPage {
>    ...

Done.

https://codereview.chromium.org/2074543003/diff/140001/components/arc/common/...
components/arc/common/app.mojom:108: [MinVersion=5] ShowPackageInfo@9(string
package_name,
On 2016/06/20 05:00:26, Yusuke Sato wrote:
> Can you rename this to ShowPackageInfoDeprecated@9 just like auth.mojom and
> intent_helper.mojom do?

Done.

https://codereview.chromium.org/2074543003/diff/140001/components/arc/test/fa...
File components/arc/test/fake_app_instance.h (right):

https://codereview.chromium.org/2074543003/diff/140001/components/arc/test/fa...
components/arc/test/fake_app_instance.h:90: mojom::ShowPackageInfoPage page,
On 2016/06/20 05:00:26, Yusuke Sato wrote:
> wrong indent?

Done.

[mtomasz, 2016-06-20 08:40:54]

Ready for review.

[dcheng, 2016-06-20 15:31:45]

https://codereview.chromium.org/2074543003/diff/180001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h
(right):

https://codereview.chromium.org/2074543003/diff/180001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h:35:
public base::SupportsWeakPtr<ArcAppInfoLinksPanel> {
Do we need this? I don't see any calls to AsWeakPtr().

https://codereview.chromium.org/2074543003/diff/180001/components/arc/common/...
File components/arc/common/app.mojom (right):

https://codereview.chromium.org/2074543003/diff/180001/components/arc/common/...
components/arc/common/app.mojom:25: MANAGE_LINKS = 1,
Perhaps explain what these different values mean? How will MAIN be used?

[Yusuke Sato, 2016-06-20 17:28:51]

components/arc/ lgtm with comments addressed.

https://codereview.chromium.org/2074543003/diff/180001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc
(right):

https://codereview.chromium.org/2074543003/diff/180001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc:18:
char kArcChromePackageName[] = "org.chromium.arc.intent_helper";
constexpr missing.

[Yusuke Sato, 2016-06-20 17:50:20]

https://codereview.chromium.org/2074543003/diff/180001/components/arc/test/fa...
File components/arc/test/fake_app_instance.cc (right):

https://codereview.chromium.org/2074543003/diff/180001/components/arc/test/fa...
components/arc/test/fake_app_instance.cc:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
one more nit:

Please also file a placeholder bug on crbug.com (with just "for b/29245776" or
something) and use the crbug.com bug for your BUG= line. Rietveld cannot update
b/ atm.

[mtomasz, 2016-06-21 00:38:01]

Description was changed from

==========
ARC: Add a link to "Manage supported links" in the Chrome app info dialog.

It should only show up when ARC is enabled.

TEST=Tested manually on Samus with ARC enabled and disabled.
BUG=b/29245776
==========

to

==========
ARC: Add a link to "Manage supported links" in the Chrome app info dialog.

It should only show up when ARC is enabled. b/29245776

TEST=Tested manually on Samus with ARC enabled and disabled.
BUG=621399
==========

[mtomasz, 2016-06-21 00:38:20]

https://codereview.chromium.org/2074543003/diff/180001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc
(right):

https://codereview.chromium.org/2074543003/diff/180001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc:18:
char kArcChromePackageName[] = "org.chromium.arc.intent_helper";
On 2016/06/20 17:28:51, Yusuke Sato wrote:
> constexpr missing.

Done.

https://codereview.chromium.org/2074543003/diff/180001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h
(right):

https://codereview.chromium.org/2074543003/diff/180001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h:35:
public base::SupportsWeakPtr<ArcAppInfoLinksPanel> {
On 2016/06/20 15:31:45, dcheng wrote:
> Do we need this? I don't see any calls to AsWeakPtr().

Right. Removed. Done.

https://codereview.chromium.org/2074543003/diff/180001/components/arc/common/...
File components/arc/common/app.mojom (right):

https://codereview.chromium.org/2074543003/diff/180001/components/arc/common/...
components/arc/common/app.mojom:25: MANAGE_LINKS = 1,
On 2016/06/20 15:31:45, dcheng wrote:
> Perhaps explain what these different values mean? How will MAIN be used?

Done.

[dcheng, 2016-06-21 18:07:19]

lgtm

[mtomasz, 2016-06-22 03:43:06]

mtomasz@chromium.org changed reviewers:
+ pkasting@google.com

[mtomasz, 2016-06-22 03:44:00]

@pkasting: PTAL at BUILD.gn
@benwells: PTAL at chrome/browser/ui/*

[Peter Kasting, 2016-06-22 05:04:51]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2016-06-22 05:04:52]

LGTM

https://codereview.chromium.org/2074543003/diff/200001/chrome/browser/ui/BUIL...
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2074543003/diff/200001/chrome/browser/ui/BUIL...
chrome/browser/ui/BUILD.gn:318: if (is_chromeos) {
Nit: Can restructure to combine with conditional above:

  if (is_chromeos) {
    ...
  } else if (!is_mac || mac_views_browser) {
    ...
  }

[Peter Kasting, 2016-06-22 05:06:21]

LGTM

[mtomasz, 2016-06-22 05:32:04]

mtomasz@chromium.org changed reviewers:
- pkasting@google.com

[mtomasz, 2016-06-22 07:03:05]

https://codereview.chromium.org/2074543003/diff/200001/chrome/browser/ui/BUIL...
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2074543003/diff/200001/chrome/browser/ui/BUIL...
chrome/browser/ui/BUILD.gn:318: if (is_chromeos) {
On 2016/06/22 05:04:52, Peter Kasting wrote:
> Nit: Can restructure to combine with conditional above:
> 
>   if (is_chromeos) {
>     ...
>   } else if (!is_mac || mac_views_browser) {
>     ...
>   }

Done.

https://codereview.chromium.org/2074543003/diff/200001/chrome/browser/ui/BUIL...
chrome/browser/ui/BUILD.gn:318: if (is_chromeos) {
On 2016/06/22 05:04:52, Peter Kasting wrote:
> Nit: Can restructure to combine with conditional above:
> 
>   if (is_chromeos) {
>     ...
>   } else if (!is_mac || mac_views_browser) {
>     ...
>   }

Done.

[mtomasz, 2016-06-23 00:22:32]

@benwells: Friendly ping :) Thanks!

[mtomasz, 2016-06-23 06:24:32]

On 2016/06/23 00:22:32, mtomasz wrote:
> @benwells: Friendly ping :) Thanks!

@pkasting: PTAL also at chrome/browser/ui/* Thanks

[mtomasz, 2016-06-23 06:26:01]

mtomasz@chromium.org changed reviewers:
+ jochen@chromium.org

[mtomasz, 2016-06-23 06:26:40]

@jochen: PTAL also at chrome/browser/ui/*. Thanks!

[Peter Kasting, 2016-06-23 07:07:20]

Mostly nits.

LGTM

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:36: constexpr int
kRemoveIconMinVersion = 9;
Nit: I normally suggest that constants used in only one place be declared in
that place instead of atop the file, as it makes their values immediately
accessible when reading the code that uses them.

If you do end up keeping these here, the order of them makes no sense to me, as
it's neither ascending by number nor ascending alphabetically (R < U). 
(Ascending by number might read more clearly, I dunno.)

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:294: VLOG(2) << "Showing package
info for " << package_name;
I realize this is consistent with the rest of this file, but logging at all is
moderately unusual, and using a VLOG level other than 1 is extremely unusual. 
Any particular reason things have to be this way?  If logging in all these
functions is really needed, isn't VLOG(1) (and asking people to restrict using
--vmodule) sufficient?

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/arc/arc_app_utils.h (right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/arc/arc_app_utils.h:61: // Deprecated. Use
ShowPackageInfoOnPage.
Do you have plans to ensure this is removed later?

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
File
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc
(right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc:36:
bridge_service_.reset(new arc::FakeArcBridgeService());
Nit: Prefer "= MakeUnique<>" where possible over bare new().

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc:54:
auth_service_ = nullptr;
Nit: Is this important?  Is someone going to read this variable after this? 
Explicitly nulling it out tells the reader that's going to occur.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:165:
app->id() == extension_misc::kChromeAppId) {
Nit: {} optional

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc
(right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc:34:
arc_prefs->AddObserver(this);
Nit: If this is going to be the same pointer as in the destructor (i.e. the
prefs object won't be copied/moved in the meantime), you can use a
ScopedObserver to manage this addition, and the destructor can just become
=default.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc:56:
NOTREACHED();
Don't put this in an else, as this is effectively handling DCHECK failure. 
Instead just do:

  DCHECK(source == manage_link_);  // Not sure DCHECK_EQ works here
  if (...)
    Close();

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h
(right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h:21: } 
// namespace extensions
Nit: Personally I find these // namespace comments clutter rather than helpful
when used on a forward-decl list like this as the list is so short no one is
going to confuse which namespace these are in.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h:36: //
views::LinkListener overrides.
Nit: Just "views::LinkListener:" is sufficient (views code can't really agree on
what convention to use for this so I just encourage the shortest one)

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h:45: //
Updates the link view.
Nit: This comment doesn't really add anything to the function name, so I'd
remove it, unless you want to expand it with more about what the function does
or when it should be called.

[mtomasz, 2016-06-23 08:51:56]

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:36: constexpr int
kRemoveIconMinVersion = 9;
On 2016/06/23 07:07:19, Peter Kasting (OOO) wrote:
> Nit: I normally suggest that constants used in only one place be declared in
> that place instead of atop the file, as it makes their values immediately
> accessible when reading the code that uses them.
> 
> If you do end up keeping these here, the order of them makes no sense to me,
as
> it's neither ascending by number nor ascending alphabetically (R < U). 
> (Ascending by number might read more clearly, I dunno.)

Sorted by number. Done.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:294: VLOG(2) << "Showing package
info for " << package_name;
On 2016/06/23 07:07:19, Peter Kasting (OOO) wrote:
> I realize this is consistent with the rest of this file, but logging at all is
> moderately unusual, and using a VLOG level other than 1 is extremely unusual. 
> Any particular reason things have to be this way?  If logging in all these
> functions is really needed, isn't VLOG(1) (and asking people to restrict using
> --vmodule) sufficient?

I don't know any context here. It's purely for consistency. I'll try to look
into the initial commit for this file for some background, but for now let's
commit as it is.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/arc/arc_app_utils.h (right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/arc/arc_app_utils.h:61: // Deprecated. Use
ShowPackageInfoOnPage.
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Do you have plans to ensure this is removed later?

I'll take care of it.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
File
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc
(right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc:36:
bridge_service_.reset(new arc::FakeArcBridgeService());
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Nit: Prefer "= MakeUnique<>" where possible over bare new().

Done.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc:54:
auth_service_ = nullptr;
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Nit: Is this important?  Is someone going to read this variable after this? 
> Explicitly nulling it out tells the reader that's going to occur.

AFAIK it's a common practice, but I don't have strong feelings here. Removed.
Done.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:165:
app->id() == extension_misc::kChromeAppId) {
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Nit: {} optional

Done.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc
(right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc:34:
arc_prefs->AddObserver(this);
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Nit: If this is going to be the same pointer as in the destructor (i.e. the
> prefs object won't be copied/moved in the meantime), you can use a
> ScopedObserver to manage this addition, and the destructor can just become
> =default.

Done.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc:56:
NOTREACHED();
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Don't put this in an else, as this is effectively handling DCHECK failure. 
> Instead just do:
> 
>   DCHECK(source == manage_link_);  // Not sure DCHECK_EQ works here
>   if (...)
>     Close();

Done.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
File chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h
(right):

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h:21: } 
// namespace extensions
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Nit: Personally I find these // namespace comments clutter rather than helpful
> when used on a forward-decl list like this as the list is so short no one is
> going to confuse which namespace these are in.

No strong feelings. Removed. Done.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h:36: //
views::LinkListener overrides.
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Nit: Just "views::LinkListener:" is sufficient (views code can't really agree
on
> what convention to use for this so I just encourage the shortest one)

Done.

https://codereview.chromium.org/2074543003/diff/220001/chrome/browser/ui/view...
chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.h:45: //
Updates the link view.
On 2016/06/23 07:07:20, Peter Kasting (OOO) wrote:
> Nit: This comment doesn't really add anything to the function name, so I'd
> remove it, unless you want to expand it with more about what the function does
> or when it should be called.

Removed. Done.

[mtomasz, 2016-06-23 13:38:37]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2016-06-23 13:38:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
yusukes@chromium.org, dcheng@chromium.org, pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2074543003/#ps240001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-06-23 13:38:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074543003/240001

[commit-bot: I haz the power, 2016-06-23 14:01:17]

Description was changed from

==========
ARC: Add a link to "Manage supported links" in the Chrome app info dialog.

It should only show up when ARC is enabled. b/29245776

TEST=Tested manually on Samus with ARC enabled and disabled.
BUG=621399
==========

to

==========
ARC: Add a link to "Manage supported links" in the Chrome app info dialog.

It should only show up when ARC is enabled. b/29245776

TEST=Tested manually on Samus with ARC enabled and disabled.
BUG=621399
==========

[commit-bot: I haz the power, 2016-06-23 14:01:19]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-06-23 14:03:32]

Description was changed from

==========
ARC: Add a link to "Manage supported links" in the Chrome app info dialog.

It should only show up when ARC is enabled. b/29245776

TEST=Tested manually on Samus with ARC enabled and disabled.
BUG=621399
==========

to

==========
ARC: Add a link to "Manage supported links" in the Chrome app info dialog.

It should only show up when ARC is enabled. b/29245776

TEST=Tested manually on Samus with ARC enabled and disabled.
BUG=621399

Committed: https://crrev.com/7cfdb68e2ca91ce3d073d4bf15bbaa5004bf120e
Cr-Commit-Position: refs/heads/master@{#401597}
==========

[commit-bot: I haz the power, 2016-06-23 14:03:33]

Patchset 13 (id:??) landed as
https://crrev.com/7cfdb68e2ca91ce3d073d4bf15bbaa5004bf120e
Cr-Commit-Position: refs/heads/master@{#401597}